[Avi-3k]

in TrayDialog.cpp the last 2 versions of TraySetIcon()
are missing the sending of the second argument bDelete,
old code:

Quote

...
void CTrayDialog::TraySetIcon(UINT nResourceID, bool bDelete)
{
  TraySetIcon(AfxGetApp()->LoadIcon(nResourceID));
}

void CTrayDialog::TraySetIcon(LPCTSTR lpszResourceName, bool bDelete)
{
  TraySetIcon(AfxGetApp()->LoadIcon(lpszResourceName));
}
...

new code:

Quote

...
void CTrayDialog::TraySetIcon(UINT nResourceID, bool bDelete)
{
  TraySetIcon(AfxGetApp()->LoadIcon(nResourceID), bDelete /* Avi3k: fix arg */);
}

void CTrayDialog::TraySetIcon(LPCTSTR lpszResourceName, bool bDelete)
{
  TraySetIcon(AfxGetApp()->LoadIcon(lpszResourceName), bDelete /* Avi3k: fix arg */);
}
...

since the default value is false, it might cause the icon
not to be destroyed but i haven't checked the calls to
these functions so i'm not sure if that's intentional or a bug

Avi3k

[tHeWiZaRdOfDoS]

Those functions are never called and could/should(?) be removed *g*
Good eye, however

[Avi-3k]

tHeWiZaRdOfDoS said:

Good eye, however

and i didn't even use my glasses

Avi3k

[Tuxman]

Of course it is called...

eMuleDlg.cpp:

	if (m_icoSysTrayCurrent)
  TraySetIcon(m_icoSysTrayCurrent, true);

[Avi-3k]

@Tuxman
the versions we were talking about are with
the LPCTSTR & UINT first argument, which call
the version u r talking about, with the HICON...

Avi3k

[Tuxman]

oh... okay.

Human error.