Official eMule-Board: A Bug In Downloadqueue.cpp? - Official eMule-Board

Jump to content


Page 1 of 1

A Bug In Downloadqueue.cpp? possible bug in auto cat assignment...

#1 User is offline   Avi-3k 

  • hebMule [retired] dev
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 1,127
  • Joined: 25-June 03

Posted 13 February 2006 - 10:28 AM

hi everybody

i think there's a bug in the auto-cat assignment.
the function responsible for the assignment will
continue working even if the cat was assigned...
i'm not sure if it was intended this way or a bug,
so please verify it, thanx :flowers:

the old code:

Quote

...
void CDownloadQueue::SetAutoCat(CPartFile* newfile){
...
  } else {
      // regular expression evaluation
      if (RegularExpressionMatch(catExt,newfile->GetFileName()))
        newfile->SetCategory(ix);
    }
...
}
...


new code:

Quote

...
void CDownloadQueue::SetAutoCat(CPartFile* newfile){
...
  } else {
      // regular expression evaluation
      if (RegularExpressionMatch(catExt,newfile->GetFileName()))
        {
            newfile->SetCategory(ix);
            return; // Avi3k: fix auto-cat assign
        }

    }
...
}
...


Regards,
Avi3k
retired developer of hebMule and eMule Skinner...
hebMule site and topic.
hebMule2 unique features: AntiLeech, AntiVirus, Fake Check, ServerFilter, WebSearches, Export Searches, Relative Priority, ModID and much much more...

eMule Skinner is an application to create/edit skins for eMule,
it's multilingual, supports mods, easy-to-use design, integrates to hebMule & Windows and lots more...

code fixes/improvements: #1, #2, #3, #4, #5, #6, #7, #8, #9, #10, #11 (to check/verify: #12, #13).
0

#2 User is offline   Borschtsch 

  • Advanced Member
  • PipPipPip
  • Group: Members
  • Posts: 77
  • Joined: 25-November 04

Posted 13 February 2006 - 03:59 PM

Avi-3k, on Feb 13 2006, 03:28 PM, said:

hi everybody

Hi.
Some times ago i wrote about SetAutoCat too. I talked about SetAutoCat was overriding category selection in Search window and when we paste ED2K-link into Transfer window.

This post has been edited by Borschtsch: 13 February 2006 - 05:46 PM

0

  • Member Options

Page 1 of 1

1 User(s) are reading this topic
0 members, 1 guests, 0 anonymous users