Official eMule-Board: Issue With Resizablelib Usage - Official eMule-Board

Jump to content


Page 1 of 1

Issue With Resizablelib Usage dialogs' implement_dynamic

#1 User is offline   Avi-3k 

  • hebMule [retired] dev
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 1,127
  • Joined: 25-June 03

Posted 19 September 2005 - 08:52 PM

i checked a code to see if i can change it
when i noticed that a class based on CResizableDialog
using this next code

Quote

IMPLEMENT_DYNAMIC(class, CDialog)

so i checked and the next files have the same code:
AddSourceDlg.cpp
ChatWnd.cpp
CollectionCreateDialog.cpp
CollectionViewDialog.cpp
DirectDownloadDlg.cpp
IPFilterDlg.cpp
IrcWnd.cpp
KademliaWnd.cpp
NetworkInfoDlg.cpp
PartFileConvert.cpp
ServerWnd.cpp
SharedFilesWnd.cpp
StatisticsDlg.cpp
TransferWnd.cpp

is that suppose to be like that?
because afaik the code should be like...:

Quote

IMPLEMENT_DYNAMIC(class, CResizableDialog)


Regards,
Avi3k
retired developer of hebMule and eMule Skinner...
hebMule site and topic.
hebMule2 unique features: AntiLeech, AntiVirus, Fake Check, ServerFilter, WebSearches, Export Searches, Relative Priority, ModID and much much more...

eMule Skinner is an application to create/edit skins for eMule,
it's multilingual, supports mods, easy-to-use design, integrates to hebMule & Windows and lots more...

code fixes/improvements: #1, #2, #3, #4, #5, #6, #7, #8, #9, #10, #11 (to check/verify: #12, #13).
0

#2 User is offline   SlugFiller 

  • The one and only master slug
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 6,988
  • Joined: 15-September 02

Posted 19 September 2005 - 10:35 PM

Well, it only matters if CResizableDialog has message handlers, and I'm not sure whether it does.
Quite frankly, you could simply use:
IMPLEMENT_DYNAMIC(class, __super)

I'm wondering why IMPLEMENT_DYNAMIC isn't written to use __super automatically to begin with. Well, M$, go fig.
Why haven't you clicked yet?

SlugFiller rule #1: Unsolicited PMs is the second most efficient method to piss me off.
SlugFiller rule #2: The first most efficient method is unsolicited eMails.
SlugFiller rule #3: If it started in a thread, it should end in the same thread.
SlugFiller rule #4: There is absolutely no reason to perform the same discussion twice in parallel, especially if one side is done via PM.
SlugFiller rule #5: Does it say "Group: Moderators" under my name? No? Then stop telling me about who you want to ban! I really don't care! Go bother a moderator.
SlugFiller rule #6: I can understand English, Hebrew, and a bit of Japanese(standard) and Chinese(mandarin), but if you speak to me in anything but English, do expect to be utterly ignored, at best.
0

#3 User is offline   Avi-3k 

  • hebMule [retired] dev
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 1,127
  • Joined: 25-June 03

Posted 21 September 2005 - 03:06 PM

afaik ResizableLib doesn't have message handlers
but imo the code should be changed so there won't
be any issues in future releases...

Avi3k
retired developer of hebMule and eMule Skinner...
hebMule site and topic.
hebMule2 unique features: AntiLeech, AntiVirus, Fake Check, ServerFilter, WebSearches, Export Searches, Relative Priority, ModID and much much more...

eMule Skinner is an application to create/edit skins for eMule,
it's multilingual, supports mods, easy-to-use design, integrates to hebMule & Windows and lots more...

code fixes/improvements: #1, #2, #3, #4, #5, #6, #7, #8, #9, #10, #11 (to check/verify: #12, #13).
0

#4 User is offline   Avi-3k 

  • hebMule [retired] dev
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 1,127
  • Joined: 25-June 03

Posted 25 September 2005 - 09:37 AM

i just checked ResizableLib and it has a message map
which i guess means the code must be changed!
if other devs can, please check it, thanx :)

Avi3k

This post has been edited by Avi-3k: 25 September 2005 - 09:37 AM

retired developer of hebMule and eMule Skinner...
hebMule site and topic.
hebMule2 unique features: AntiLeech, AntiVirus, Fake Check, ServerFilter, WebSearches, Export Searches, Relative Priority, ModID and much much more...

eMule Skinner is an application to create/edit skins for eMule,
it's multilingual, supports mods, easy-to-use design, integrates to hebMule & Windows and lots more...

code fixes/improvements: #1, #2, #3, #4, #5, #6, #7, #8, #9, #10, #11 (to check/verify: #12, #13).
0

#5 User is offline   tHeWiZaRdOfDoS 

  • Man, what a bunch of jokers...
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 5,630
  • Joined: 28-December 02

Posted 25 September 2005 - 09:48 AM

The question is wether one needs that RUNTIME_CLASS macro and the ::IsKindOf routine anyways (thinking about SlugFillers' 'remove IsKindOf' changes...)
0

#6 User is offline   Avi-3k 

  • hebMule [retired] dev
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 1,127
  • Joined: 25-June 03

Posted 25 September 2005 - 12:33 PM

@Wiz
those are not the only things which matter.
some stuff which need CResizableDialog for example
could not work because the code differs.
(i had the same issue in Skinner in another mfc class)

Avi3k
retired developer of hebMule and eMule Skinner...
hebMule site and topic.
hebMule2 unique features: AntiLeech, AntiVirus, Fake Check, ServerFilter, WebSearches, Export Searches, Relative Priority, ModID and much much more...

eMule Skinner is an application to create/edit skins for eMule,
it's multilingual, supports mods, easy-to-use design, integrates to hebMule & Windows and lots more...

code fixes/improvements: #1, #2, #3, #4, #5, #6, #7, #8, #9, #10, #11 (to check/verify: #12, #13).
0

#7 User is offline   tHeWiZaRdOfDoS 

  • Man, what a bunch of jokers...
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 5,630
  • Joined: 28-December 02

Posted 25 September 2005 - 01:40 PM

Honestly I'm lacking knowledge about MFC - but what effects does the DYNAMIC have aside from the 2 things I mentioned?

PS: there are a *lot* of other type mismatches around, e.g. usage of CListCtrl instead of CMuleListCtrl and so on... though I never really cared as I dunno about the impacts...

This post has been edited by tHeWiZaRdOfDoS: 25 September 2005 - 01:42 PM

0

#8 User is offline   Avi-3k 

  • hebMule [retired] dev
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 1,127
  • Joined: 25-June 03

Posted 25 September 2005 - 03:39 PM

the best way to explain is by an example, like in Skinner:
i added icons to the combo box and it didn't work
even though i changed the code in TreeOptionsCtrl.h
from CComboBox to CComboBoxEx.
after i changed the code in TreeOptionsCtrl.cpp it worked ok...

it turns out that the macros creates an array of the messages
by a structure with base classes maps etc...
(u can check the afxwin.h file in the mfc include folder
from approx. line 1030 in VS.net v7.1.3077)

Avi3k
retired developer of hebMule and eMule Skinner...
hebMule site and topic.
hebMule2 unique features: AntiLeech, AntiVirus, Fake Check, ServerFilter, WebSearches, Export Searches, Relative Priority, ModID and much much more...

eMule Skinner is an application to create/edit skins for eMule,
it's multilingual, supports mods, easy-to-use design, integrates to hebMule & Windows and lots more...

code fixes/improvements: #1, #2, #3, #4, #5, #6, #7, #8, #9, #10, #11 (to check/verify: #12, #13).
0

  • Member Options

Page 1 of 1

1 User(s) are reading this topic
0 members, 1 guests, 0 anonymous users