[Avi-3k]

i checked a code to see if i can change it
when i noticed that a class based on CResizableDialog
using this next code

Quote

IMPLEMENT_DYNAMIC(class, CDialog)

so i checked and the next files have the same code:
AddSourceDlg.cpp
ChatWnd.cpp
CollectionCreateDialog.cpp
CollectionViewDialog.cpp
DirectDownloadDlg.cpp
IPFilterDlg.cpp
IrcWnd.cpp
KademliaWnd.cpp
NetworkInfoDlg.cpp
PartFileConvert.cpp
ServerWnd.cpp
SharedFilesWnd.cpp
StatisticsDlg.cpp
TransferWnd.cpp

is that suppose to be like that?
because afaik the code should be like...:

Quote

IMPLEMENT_DYNAMIC(class, CResizableDialog)

Regards,
Avi3k

[SlugFiller]

Well, it only matters if CResizableDialog has message handlers, and I'm not sure whether it does.
Quite frankly, you could simply use:

IMPLEMENT_DYNAMIC(class, __super)

I'm wondering why IMPLEMENT_DYNAMIC isn't written to use __super automatically to begin with. Well, M$, go fig.

[Avi-3k]

afaik ResizableLib doesn't have message handlers
but imo the code should be changed so there won't
be any issues in future releases...

Avi3k

[Avi-3k]

i just checked ResizableLib and it has a message map
which i guess means the code must be changed!
if other devs can, please check it, thanx

Avi3k

This post has been edited by Avi-3k: 25 September 2005 - 09:37 AM

[tHeWiZaRdOfDoS]

The question is wether one needs that RUNTIME_CLASS macro and the ::IsKindOf routine anyways (thinking about SlugFillers' 'remove IsKindOf' changes...)

[Avi-3k]

@Wiz
those are not the only things which matter.
some stuff which need CResizableDialog for example
could not work because the code differs.
(i had the same issue in Skinner in another mfc class)

Avi3k

[tHeWiZaRdOfDoS]

Honestly I'm lacking knowledge about MFC - but what effects does the DYNAMIC have aside from the 2 things I mentioned?

PS: there are a *lot* of other type mismatches around, e.g. usage of CListCtrl instead of CMuleListCtrl and so on... though I never really cared as I dunno about the impacts...

This post has been edited by tHeWiZaRdOfDoS: 25 September 2005 - 01:42 PM

[Avi-3k]

the best way to explain is by an example, like in Skinner:
i added icons to the combo box and it didn't work
even though i changed the code in TreeOptionsCtrl.h
from CComboBox to CComboBoxEx.
after i changed the code in TreeOptionsCtrl.cpp it worked ok...

it turns out that the macros creates an array of the messages
by a structure with base classes maps etc...
(u can check the afxwin.h file in the mfc include folder
from approx. line 1030 in VS.net v7.1.3077)

Avi3k