[tHeWiZaRdOfDoS]

Since a few versions, eMule features a "queue-overflow" mechanism, though, this is annoying for a lot of users, they want their set limit to be kept, that's why I thought of changing that code:

UploadQueue.cpp:

Quote

  // cap the list
    // the queue limit in prefs is only a soft limit. Hard limit is 25% higher, to let in powershare clients and other
    // high ranking clients after soft limit has been reached
    uint32 softQueueLimit = thePrefs.GetQueueSize();
    uint32 hardQueueLimit = thePrefs.GetQueueSize() + max(thePrefs.GetQueueSize()/4, 200);

into:

Quote

  // cap the list
    // the queue limit in prefs is only a soft limit. Hard limit is 25% higher, to let in powershare clients and other
    // high ranking clients after soft limit has been reached
    uint32 hardQueueLimit = thePrefs.GetQueueSize();
    uint32 softQueueLimit = thePrefs.GetQueueSize()/1.25f;
    if(hardQueueLimit - softQueueLimit < 200)
        softQueueLimit = hardQueueLimit-200;   

This will make hardlimit to be kept and at least 200 places as "buffer" in the queue


BTW is /1.25f much slower than *0.8f?

[SlugFiller]

Quote

BTW is /1.25f much slower than *0.8f?

About 5-10 times slower, last I checked. Besides, since it's ints, combinations of << and >> would be better suited for math with constants.

[CiccioBastardo]

You can also use 2 int operators instead of 1 floating, like doing a multiplication for 4 (thus maybe better a << 2) and dividing by 5 in this particular case.

[zz]

When I tested this, it mostly obeyed the soft limit, and hardly ever went up to the hard limit. The soft limit can be passed for a while right after you started the application, and just after you've rearranged your file ul priorities, but after a while it will creep down to the soft limit again.

So I think the change above will cause the queue to be at 80% of the limit most of the time, which wouldn't be good.

/zz

[tHeWiZaRdOfDoS]

It depends on which CS you use, the Pawcio CS boosts new clients so the queue will soon fill up... that's why I called it a FiX with a questionmark... there WILL be people that will use it and other won't - personally, I like it my way, too...

[zz]

Yeah that would cause a problem, that's true. Should be ok in standard eMule though.

/zz