Official eMule-Board: Feature: Zz Slotfocus - Official eMule-Board

Jump to content


  • (7 Pages)
  • +
  • « First
  • 2
  • 3
  • 4
  • 5
  • 6
  • Last »

Feature: Zz Slotfocus Faster completion of chunks during UL

#61 User is offline   ecvej 

  • Member
  • PipPip
  • Group: Members
  • Posts: 22
  • Joined: 15-March 04

Posted 09 October 2005 - 10:54 AM

Hi, this feature works fine for me so thanks for this.

My problem however is that this feature works too well :worthy:

My situation was that emule had been running constantly for about a month. Somebody contacted me in PM and asked for a friend slot. As the file was rare I agreed as I wanted to help it spread. However, I had to reboot my pc only moments before the friend slot was granted.

The result was that even though i was doing a good thing and spreading a rare file, because my session was deemed to just have started due to the restart i fell foul of 1:3 ratio for sharing. My friend took my enitre bandwidth because of this feature.

Anyway, i had some ideas on how it might be resolved:-

* It might be a good idea therefore if this feature could temporarily be disabled so that upload is shared equally between many users
* Perhaps this feature could recognise not to give full bandwidth to a friend if close to the 1:3 ratio
* This feature should be customizable, eg specifying a max speed per slot.
* Friend slot feature should be more customizable, eg i specify i want my friend to take 'x' KB/s and the rest is focused on a non friend.
* ZZUL should recognise that I have just started a session so my 1:3 ratio is very easily breached. Perhaps it shouldnt take a longer term view rather than punish me for needing to restart.

Personally i prefer the 4th option, any thoughts?
0

#62 User is offline   Andu 

  • Morph Team
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 13015
  • Joined: 04-December 02

Posted 09 October 2005 - 12:17 PM

#4 is already part of Morph. Not sure if the bugs that it had concerning USC have been resolved tho.
Three Rings for the Elven-kings under the sky,
Seven for the Dwarf-lords in their halls of stone,
Nine for Mortal Men doomed to die,
One for the Dark Lord on his dark throne
In the Land of Mordor where the Shadows lie.
One Ring to rule them all, One Ring to find them,
One Ring to bring them all and in the darkness bind them
In the Land of Mordor where the Shadows lie.


Dark Lord of the Forum


Morph your Mule

Need a little help with your MorphXT? Click here

0

#63 User is offline   CiccioBastardo 

  • Doomsday Executor
  • PipPipPipPipPipPipPip
  • Group: Italian Moderators
  • Posts: 5541
  • Joined: 22-November 03

Posted 09 October 2005 - 12:29 PM

Friend slots should be used only to distribute an entire file to someone who can help you spreading the file better. Not for rewarding someone of some upload he did. Slotfocus on friend slot is the best way to spread a file faster, if that's the real intention.
We all happily ban kick&push featured mods, but then we use the friends slot for the same purposes.
I think the 1:3 ratio should be accounted from the start for many reasons. One is that otherwise it is exploitable (you can restart when the granted time is over).
The problem is not the client, it's the user
0

#64 User is offline   jicxicmic 

  • Premium Member
  • PipPipPipPipPip
  • Group: Members
  • Posts: 279
  • Joined: 08-November 02

Posted 07 November 2005 - 11:34 AM

Hi zz,

Recently I give a try to your mod since I found very interesting this feature, But I seen more than 3 times a situation That I don't understand. Seems that the Slot one is not set to the oldest client in Upload queue, is just a glitch on display ? or there is another reason ?
If I sort the upload list, I see that the slot number 1 is newest than others, I mean, that I expect to see something like that.

Slot Transfering time
1 10:15
2 8:50
3 5:30
4 1:10

but I found

Slot Transfering Time
2 10:15
1 8:50
3 5:30
4 1:1


Chears
0

#65 User is offline   zz 

  • -
  • PipPipPipPipPipPipPip
  • Group: Debugger
  • Posts: 2014
  • Joined: 30-November 02

Posted 07 November 2005 - 12:29 PM

Powershare and low id connect can make a slot skip ahead before other slot when it connects.

/zz B)
ZZUL - get control of your uploads: ZZUL Forum
0

#66 User is offline   jicxicmic 

  • Premium Member
  • PipPipPipPipPip
  • Group: Members
  • Posts: 279
  • Joined: 08-November 02

Posted 07 November 2005 - 01:09 PM

Hi zz,
I've PowerShare not enabled. Just replaced an Official Emule 46c by your executable. Without modify any parameter nor enabling any feature by hand.

About LowID, I've HighID, didn't check if that client has or not LowID.

Chears
0

#67 User is offline   tHeWiZaRdOfDoS 

  • Man, what a bunch of jokers...
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 5630
  • Joined: 28-December 02

Posted 07 November 2005 - 02:47 PM

@jicxicmic: AFAIK the slots are sorted by the requested files priority
0

#68 User is offline   jicxicmic 

  • Premium Member
  • PipPipPipPipPip
  • Group: Members
  • Posts: 279
  • Joined: 08-November 02

Posted 07 November 2005 - 04:09 PM

@tHeWiZaRdOfDoS

All the priorities are normal. I Don't like the auto priorities.
0

#69 User is offline   tHeWiZaRdOfDoS 

  • Man, what a bunch of jokers...
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 5630
  • Joined: 28-December 02

Posted 07 November 2005 - 05:54 PM

Hmmm I *guess* you mean the DL-prio, don't you? I'm talking about upload prio - they are all the same, too?
0

#70 User is offline   jicxicmic 

  • Premium Member
  • PipPipPipPipPip
  • Group: Members
  • Posts: 279
  • Joined: 08-November 02

Posted 07 November 2005 - 10:16 PM

@tHeWiZaRdOfDoS

I'm Talking about UpLoad.
0

#71 User is offline   CiccioBastardo 

  • Doomsday Executor
  • PipPipPipPipPipPipPip
  • Group: Italian Moderators
  • Posts: 5541
  • Joined: 22-November 03

Posted 08 November 2005 - 07:50 AM

ZZUL reorders the upload slots, as zz said, when a low ID client connects that should have been granted a slot before the callback or when a powershared file is requested.
If you don't have any PS file, then it is more likely the at lest one of those was a LowID client.

@Wizard
Can't remember a resort by file priority, though I may not remember right. For sure slots are not reordered by score after they've been started (so a client with a lower score is not preempted if one with a higher score obtains an upload slot).
Should check the code, though zz may be more precide on this.
The problem is not the client, it's the user
0

#72 User is offline   tHeWiZaRdOfDoS 

  • Man, what a bunch of jokers...
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 5630
  • Joined: 28-December 02

Posted 08 November 2005 - 03:56 PM

Alright I found the codepart:

Quote

    while(pos != NULL && foundposition == false) {
        CUpDownClient* uploadingClient = uploadinglist.GetAt(pos);

  if(uploadingClient->IsScheduledForRemoval() == false && newclient->IsScheduledForRemoval() == true ||
    uploadingClient->IsScheduledForRemoval() == newclient->IsScheduledForRemoval() &&
          (
            uploadingClient->HasCollectionUploadSlot() && !newclient->HasCollectionUploadSlot() ||
            uploadingClient->HasCollectionUploadSlot() == newclient->HasCollectionUploadSlot() &&
            (
          (uploadingClient->IsFriend() && uploadingClient->GetFriendSlot()) == true && (newclient->IsFriend() && newclient->GetFriendSlot()) == false ||
            (uploadingClient->IsFriend() && uploadingClient->GetFriendSlot()) == (newclient->IsFriend() && newclient->GetFriendSlot()) &&
            (
              uploadingClient->GetPowerShared() == true && newclient->GetPowerShared() == false ||
              uploadingClient->GetPowerShared() == true && newclient->GetPowerShared() == true && uploadingClient->GetFilePrioAsNumber() > newclient->GetFilePrioAsNumber() ||
              (
                uploadingClient->GetPowerShared() == true && newclient->GetPowerShared() == true && uploadingClient->GetFilePrioAsNumber() == newclient->GetFilePrioAsNumber() ||
                uploadingClient->GetPowerShared() == false && newclient->GetPowerShared() == false
              ) &&
              (
              //uploadingClient->GetDatarate() > newclient->GetDatarate() ||
              //uploadingClient->GetDatarate() == newclient->GetDatarate() &&
              !newclient->IsScheduledForRemoval() &&
              (
                !newclient->HasLowID() ||
                !newclient->m_dwWouldHaveGottenUploadSlotIfNotLowIdTick ||
                newclient->HasLowID() && newclient->m_dwWouldHaveGottenUploadSlotIfNotLowIdTick && (::GetTickCount()-newclient->m_dwWouldHaveGottenUploadSlotIfNotLowIdTick) <= uploadingClient->GetUpStartTimeDelay()
              ) ||
              newclient->IsScheduledForRemoval() &&
              (
                !newclient->GetScheduledUploadShouldKeepWaitingTime()
              )
              )
            )
            )
          )
          ) {
            foundposition = true;
        } else {
            insertPosition = pos;
            uploadinglist.GetPrev(pos);
            posCounter--;
        }
    }

So sort is:
close to removal --> Collection (Small file slot) --> FriendSlot --> PowerShare + FilePrio --> LowID (?)
0

#73 User is offline   CiccioBastardo 

  • Doomsday Executor
  • PipPipPipPipPipPipPip
  • Group: Italian Moderators
  • Posts: 5541
  • Joined: 22-November 03

Posted 08 November 2005 - 04:45 PM

Isn't priority considered only for powershared files?
The problem is not the client, it's the user
0

#74 User is offline   tHeWiZaRdOfDoS 

  • Man, what a bunch of jokers...
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 5630
  • Joined: 28-December 02

Posted 08 November 2005 - 05:08 PM

Quote

PowerShare + FilePrio

Yeah... I said that?
0

#75 User is offline   zz 

  • -
  • PipPipPipPipPipPipPip
  • Group: Debugger
  • Posts: 2014
  • Joined: 30-November 02

Posted 08 November 2005 - 06:07 PM

Wizard: close to removal is sorted last, but internally sorted according to the list you gave, except that the preempted clients are more worth than completing clients.

Lol at the complexity of that sorting. :)

/zz B)
ZZUL - get control of your uploads: ZZUL Forum
0

#76 User is offline   CiccioBastardo 

  • Doomsday Executor
  • PipPipPipPipPipPipPip
  • Group: Italian Moderators
  • Posts: 5541
  • Joined: 22-November 03

Posted 08 November 2005 - 07:23 PM

Wizard said:

@jicxicmic: AFAIK the slots are sorted by the requested files priority

:-k

:flowers:
The problem is not the client, it's the user
0

#77 User is offline   j7n 

  • Advanced Member
  • PipPipPip
  • Group: Members
  • Posts: 65
  • Joined: 30-December 05

Posted 03 May 2006 - 09:21 AM

I am a rather happy user of ZZUL since 0.46. SlotFocus is indeed a great feature.

But in some circumstances – occasional load on the network or my machine perhaps – it still opens too many slots. I have allocated 64 kB/s of bandwidth to eMule and I think it can be divided to at most 5 peers. Unfortunately it is quite common to see like 12 upload connections established. Most ppl here at the forums agree that a fixed number of slots would not be beneficial to the network. How about max number? So in my case eMule would never open more than 6.

I don't think I need USS as I already know I have stable 1 MBit/s. Those occasional speed drops are random and no software can predict them.

This post has been edited by j7n: 03 May 2006 - 09:21 AM

0

#78 User is offline   bitter001 

  • Newbie
  • Pip
  • Group: Members
  • Posts: 4
  • Joined: 22-April 06

Posted 11 May 2006 - 04:19 AM

j7n, on May 3 2006, 05:21 PM, said:

I am a rather happy user of ZZUL since 0.46. SlotFocus is indeed a great feature.

But in some circumstances – occasional load on the network or my machine perhaps – it still opens too many slots. I have allocated 64 kB/s of bandwidth to eMule and I think it can be divided to at most 5 peers. Unfortunately it is quite common to see like 12 upload connections established. Most ppl here at the forums agree that a fixed number of slots would not be beneficial to the network. How about max number? So in my case eMule would never open more than 6.

I don't think I need USS as I already know I have stable 1 MBit/s. Those occasional speed drops are random and no software can predict them.
View Post



I think the algorithm is trying to use all your avaiable upload bandwidth and upload to more clients when some of the clients has a slow connection. :confused: As I am using ASDL modem, I just allocated 42kB/s of upload bandwith. ZZUL mod normally provide 5 to 8 upload slot. If there are more clients with LowID, there are more slots are opened. My highest number of upload slots is 14. :huh:
0

#79 User is offline   gigatoaster 

  • Shpongle is my life
  • PipPipPipPipPipPipPip
  • Group: Moderator
  • Posts: 7411
  • Joined: 13-December 03

Posted 08 August 2006 - 04:04 AM

Hi!

The question has not been asked for one year, yet :

would it be possible AT LEAST to have this feature in the official clients? It would be awesome... :flowers:

#80 User is offline   MadlyMad 

  • Golden eMule
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 3745
  • Joined: 29-October 02

Posted 08 August 2006 - 11:58 AM

:+1: :+1:

The extreme limit of wisdom, that is what the public calls madness.
0

  • Member Options

  • (7 Pages)
  • +
  • « First
  • 2
  • 3
  • 4
  • 5
  • 6
  • Last »

1 User(s) are reading this topic
0 members, 1 guests, 0 anonymous users