[Enig123]

In line 635 of kademlia\kademlia\Search.cpp,

			// Get our clientID for the packet.
			CUInt128 uID(CKademlia::GetPrefs()->GetClientHash());

it supposed to be the client ID there, what does client ID mean? Is it client hash or just kad id?

The uID is then used to send a packet in line 694:

			// Send packet
			CKademlia::GetUDPListener()->SendPublishSourcePacket(pFromContact, m_uTarget, uID, listTag);

and the routine is implemented in kademlia\net\KademliaUDPListener.cpp starting with line 190, in which 'KADEMLIA2_PUBLISH_SOURCE_REQ' is sent.

I am a little confused, since other variable naming indicating perhaps GetKadID should be used instead?

This post has been edited by Enig123: 18 March 2025 - 09:06 AM

[Enig123]

Never mind. Digging into the codes a little deeper today, and I realized the UInt128 here is transferred to remote peer as the ed2k userhash, thus the use of GetClientHash() right here is correct, actually.

I know kademlia has proved its maturity after running efficiently all these years, probably that's why it's so hard to find an unknown bug at this point.