Official eMule-Board: V0.60d Statistics: 5 Min Average Graph Wrong With High Upload Rates - Official eMule-Board

Jump to content


Page 1 of 1

V0.60d Statistics: 5 Min Average Graph Wrong With High Upload Rates

#1 User is offline   ajgelado 

  • Newbie
  • Pip
  • Group: Members
  • Posts: 14
  • Joined: 07-August 23

Posted 07 August 2023 - 09:01 AM

After getting upgraded to symmetric 300 mbps fibre, I started noticing that when many clients are downloading from my computer, sometimes the upload speed graph is wrong. Specifically, the 5 minute average line seems to tip over a certain limit and "wrap around" to zero. You can see that in this image: https:--ibb.co-2hb3HPB (replace dashes with slashes to get the image URL - the forum won't let me insert the image or a link to it in the post).

By doing some maths, it seems that the problem is triggered when the uploads sum more than 4 GB over the last 5 minutes. It seems, thus, that the problem lies in the use of an unsigned 32 bit integer to calculate the total, and the fix may be using a 64-bit integer. I have not looked into the source code, so I can't say that for sure.

Expected behaviour: the 5 minute average upload speed graph is right at every upload rate.

Seen behaviour: the graph is wrong at high rates, approximately equal to or above 4 GB per 5 minutes.

When it happens: in a high speed connection, every time the upload rate exceeds the said threshold.

Affected versions: tested with eMule v0.60d x86.
0

#2 User is offline   ajgelado 

  • Newbie
  • Pip
  • Group: Members
  • Posts: 14
  • Joined: 07-August 23

Posted 07 August 2023 - 03:56 PM

Another screenshot showing more clearly the same problem: https:--ibb.co-7KQLxNc (as before, replace dashes with slashes).
0

#3 User is offline   fox88 

  • Golden eMule
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 4974
  • Joined: 13-May 07

Posted 18 August 2023 - 05:27 PM

Thanks for the report.
The issue should be resolved in 0.70a - currently in beta testing.
0

#4 User is offline   ajgelado 

  • Newbie
  • Pip
  • Group: Members
  • Posts: 14
  • Joined: 07-August 23

Posted 19 August 2023 - 05:36 AM

Thanks for the fix. I have installed v0.70a beta, and I'm currently testing it. It depends on the demand the clients put on my files, and I have to catch it at the right moment, so I don't know when I will be able to confirm if the fix works. I'll keep an eye on it, and tell you when my eMule have reached the conditions known to trigger the bug.

By the way: where can I get a changelog of v0.70a? I'd be interested in testing the changes for regressions (in fact, I have opened another topic with a problem I have found in search results), but in GitHub all I can get is a detailed diff between v0.60d and v0.70a, which has so much detail that it's unusable for my purposes.
0

#5 User is offline   ajgelado 

  • Newbie
  • Pip
  • Group: Members
  • Posts: 14
  • Joined: 07-August 23

Posted 19 August 2023 - 11:03 AM

I can confirm that the fix works. You can see it in action in this screenshot: https:--ibb.co-9HB2ygX (replace dashes with slashes).

With the bug, the 5 minute average line (bright red) would have been "chopped" just bellow the 150 Mbps dotted line. In the screenshot, it can be seen that it goes well above that threshold, with a natural rounded form.
0

#6 User is offline   fox88 

  • Golden eMule
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 4974
  • Joined: 13-May 07

Posted 26 August 2023 - 12:39 PM

Should be fixed in beta build 2.
0

  • Member Options

Page 1 of 1

1 User(s) are reading this topic
0 members, 1 guests, 0 anonymous users