Official eMule-Board: Testing Emule 0.60A (Completed) - Official eMule-Board

Jump to content


  • (7 Pages)
  • +
  • « First
  • 5
  • 6
  • 7

Testing Emule 0.60A (Completed) Community version

#121 User is offline   p033928 

  • Advanced Member
  • PipPipPip
  • Group: Members
  • Posts: 77
  • Joined: 28-July 17

Posted 31 October 2020 - 05:18 PM

View Postzappatore77, on 31 October 2020 - 04:36 PM, said:

View Postp033928, on 31 October 2020 - 03:03 PM, said:

thxs but..i prefer the bug to be solved..
;)

that's right, this would be a very good thing indeed.


..so we are waitin for news from fox88....
;)
0

#122 User is offline   fox88 

  • Golden eMule
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 4747
  • Joined: 13-May 07

Posted 04 November 2020 - 05:07 PM

The bug with the Preview menu item will be fixed a little later.

Please keep posting bug reports, but make these more descriptive than terse "not working" or "I have an issue".
Quoting from sticky topic in Bug reports forum:
Please try to explain what you was doing when it happened. Also, try to reproduce the bug so you can explain how to reproduce it here.

0

#123 User is offline   zappatore77 

  • Newbie
  • Pip
  • Group: Members
  • Posts: 7
  • Joined: 29-October 20

Posted 04 November 2020 - 08:01 PM

View Postfox88, on 04 November 2020 - 05:07 PM, said:

The bug with the Preview menu item will be fixed a little later.

Please keep posting bug reports, but make these more descriptive than terse "not working" or "I have an issue".
Quoting from sticky topic in Bug reports forum:
Please try to explain what you was doing when it happened. Also, try to reproduce the bug so you can explain how to reproduce it here.

My situation is as follows: emule 0.60a installed on Windows 7 Pro and Windows 10 Pro (both updated with the latest versions and patches available via Windows Update).
I try to download a video file after setting emule to download the parts necessary for previewing first.
After downloading about 150 mega I take the mouse on the file being downloaded, I click with the right button and in the menu that opens I always see the gray and non-clickable preview button.
By downloading the same file on the same PCs and using version 0.51d with identical configuration to 0.60a the preview works correctly.
If you need more details please ask or tell me where I can go to look for them.
Thank you!
0

#124 User is offline   p033928 

  • Advanced Member
  • PipPipPip
  • Group: Members
  • Posts: 77
  • Joined: 28-July 17

Posted 05 November 2020 - 04:48 PM

View Postfox88, on 04 November 2020 - 05:07 PM, said:

The bug with the Preview menu item will be fixed a little later.

Please keep posting bug reports, but make these more descriptive than terse "not working" or "I have an issue".
Quoting from sticky topic in Bug reports forum:
Please try to explain what you was doing when it happened. Also, try to reproduce the bug so you can explain how to reproduce it here.


really think that zappatore77 has just furnished you -all- the data required...
0

#125 User is offline   Stulle 

  • [Enter Mod] Dev
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 5754
  • Joined: 07-April 04

Posted 25 November 2020 - 06:06 PM

I guess there is a dupe RefreshData() here:
BOOL CCommentDialogLst::OnSetActive()
{
	if (!CResizablePage::OnSetActive())
		return FALSE;
	if (m_bDataChanged) {
		RefreshData();
		RefreshData(); // I am redundant
		m_bDataChanged = false;
	}
	return TRUE;
}

I am an emule-web.de member and fan!

[Imagine there was a sarcasm meter right here!]

No, there will not be a new version of my mods. No, I do not want your PM. No, I am certain, use the board and quit sending PMs. No, I am not kidding, there will not be a new version of my mods just because of YOU asking for it!
0

#126 User is offline   p033928 

  • Advanced Member
  • PipPipPip
  • Group: Members
  • Posts: 77
  • Joined: 28-July 17

Posted 25 November 2020 - 08:14 PM

View PostStulle, on 25 November 2020 - 06:06 PM, said:

I guess there is a dupe RefreshData() here:
BOOL CCommentDialogLst::OnSetActive()
{
	if (!CResizablePage::OnSetActive())
		return FALSE;
	if (m_bDataChanged) {
		RefreshData();
		RefreshData(); // I am redundant
		m_bDataChanged = false;
	}
	return TRUE;
}



...for what is worth...??..
:(
0

#127 User is offline   Stulle 

  • [Enter Mod] Dev
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 5754
  • Joined: 07-April 04

Posted 26 November 2020 - 10:01 AM

I believe there could be a regression in CDirectoryTreeCtrl::SetSharedDirectories(CStringList &list) or is it an undocumented feature?.

It used to be:
		if (str.Left(2)==_T("\\\\")) continue;
		if (str.Right(1) != _T('\\'))
			str += _T('\\');
		m_lstShared.AddTail(str);


Now it's:
		if (str.Left(2) != _T("\\\\"))
			slosh(str);
		m_lstShared.AddTail(str);


So if we get two backslashes at the beginning of the string (e.g. network share) we actually add it to the list of shared files now. To retain the original functionality it should be:

		if (str.Left(2) == _T("\\\\"))
			continue;
		slosh(str);


EDIT:
Found another one although it's not so much a bug as an inconsistency which can increase the load for the tiniest bit. Was:
bool CDirectoryTreeCtrl::IsShared(CString strDir)
{
	if (strDir.Right(1) != _T('\\'))
		strDir += _T('\\');
	for (POSITION pos = m_lstShared.GetHeadPosition(); pos != NULL; )
	{
		CString str = m_lstShared.GetNext(pos);
		if (str.Right(1) != _T('\\'))
			str += _T('\\');
		if (str.CompareNoCase(strDir) == 0)
			return true;
	}
	return false;
}


Is:
bool CDirectoryTreeCtrl::IsShared(const CString &strDir)
{
	CString sDir(strDir);
	unslosh(sDir);
	for (POSITION pos = m_lstShared.GetHeadPosition(); pos != NULL; ) {
		CString str = m_lstShared.GetNext(pos);
		unslosh(str);
		if (str.CompareNoCase(sDir) == 0)
			return true;
	}
	return false;
}


Should be:
bool CDirectoryTreeCtrl::IsShared(const CString &strDir)
{
	CString sDir(strDir);
	slosh(sDir);
	for (POSITION pos = m_lstShared.GetHeadPosition(); pos != NULL; ) {
		CString str = m_lstShared.GetNext(pos);
		slosh(str);
		if (str.CompareNoCase(sDir) == 0)
			return true;
	}
	return false;
}


No point in removing the trailing backslash here if we just added it before calling the function (e.g. from CDirectoryTreeCtrl::AddShare or CDirectoryTreeCtrl::DelShare).

This post has been edited by Stulle: 26 November 2020 - 10:32 AM

I am an emule-web.de member and fan!

[Imagine there was a sarcasm meter right here!]

No, there will not be a new version of my mods. No, I do not want your PM. No, I am certain, use the board and quit sending PMs. No, I am not kidding, there will not be a new version of my mods just because of YOU asking for it!
1

#128 User is offline   p033928 

  • Advanced Member
  • PipPipPip
  • Group: Members
  • Posts: 77
  • Joined: 28-July 17

Posted 26 November 2020 - 11:38 AM

View PostStulle, on 26 November 2020 - 10:01 AM, said:

I believe there could be a regression in CDirectoryTreeCtrl::SetSharedDirectories(CStringList &list) or is it an undocumented feature?.

It used to be:
		if (str.Left(2)==_T("\\\\")) continue;
		if (str.Right(1) != _T('\\'))
			str += _T('\\');
		m_lstShared.AddTail(str);


Now it's:
		if (str.Left(2) != _T("\\\\"))
			slosh(str);
		m_lstShared.AddTail(str);


So if we get two backslashes at the beginning of the string (e.g. network share) we actually add it to the list of shared files now. To retain the original functionality it should be:

		if (str.Left(2) == _T("\\\\"))
			continue;
		slosh(str);


EDIT:
Found another one although it's not so much a bug as an inconsistency which can increase the load for the tiniest bit. Was:
bool CDirectoryTreeCtrl::IsShared(CString strDir)
{
	if (strDir.Right(1) != _T('\\'))
		strDir += _T('\\');
	for (POSITION pos = m_lstShared.GetHeadPosition(); pos != NULL; )
	{
		CString str = m_lstShared.GetNext(pos);
		if (str.Right(1) != _T('\\'))
			str += _T('\\');
		if (str.CompareNoCase(strDir) == 0)
			return true;
	}
	return false;
}


Is:
bool CDirectoryTreeCtrl::IsShared(const CString &strDir)
{
	CString sDir(strDir);
	unslosh(sDir);
	for (POSITION pos = m_lstShared.GetHeadPosition(); pos != NULL; ) {
		CString str = m_lstShared.GetNext(pos);
		unslosh(str);
		if (str.CompareNoCase(sDir) == 0)
			return true;
	}
	return false;
}


Should be:
bool CDirectoryTreeCtrl::IsShared(const CString &strDir)
{
	CString sDir(strDir);
	slosh(sDir);
	for (POSITION pos = m_lstShared.GetHeadPosition(); pos != NULL; ) {
		CString str = m_lstShared.GetNext(pos);
		slosh(str);
		if (str.CompareNoCase(sDir) == 0)
			return true;
	}
	return false;
}


No point in removing the trailing backslash here if we just added it before calling the function (e.g. from CDirectoryTreeCtrl::AddShare or CDirectoryTreeCtrl::DelShare).



...to be much more clear..??..
to land on the common earth of us not so much skilled...??
0

#129 User is offline   fox88 

  • Golden eMule
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 4747
  • Joined: 13-May 07

Posted 26 November 2020 - 12:07 PM

Stulle, thanks for your efforts.

Duplication was probably due to unnoticed Ctrl+D. Luckily, harmless.

I will check for possible issues with double backslash and network shares.

IsShared could be called from different places; possibly sometimes it was necessary.
Anyway, the code has already changed to use backslash termination for all eMule directories.


p033928, this all was not addressed to you.
Please avoid overquoting; or even better - delete your latest two or three messages here.
0

#130 User is offline   Stulle 

  • [Enter Mod] Dev
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 5754
  • Joined: 07-April 04

Posted 26 November 2020 - 02:21 PM

It's prolly not about skill. It's more about how much of a pedantic nerd you are when doing the merge. Since these lines were close to MorphXT code I just stumbled upon them. Anyhow, since there is so much reformatting and refactoring going on in the eMule Community code I have basically decided to go the extra mile and be as pedantic as I can be without going insane. Chances are these won't be my last finds.

Edit: About IsShared yes, called from multiple places, most of which I traced to use slosh just before. Only one place I did not check to the very root and that was the call from here:

	// add right clicked folder, if any
	if (hItem) {
		m_strLastRightClicked = GetFullPath(hItem);
		if (!IsShared(m_strLastRightClicked)) {

There is was never any explicit "slosh" there in the old code but it was there in IsShared in the first place so I wouldn't know where things could've changed. But then, I am not yet finished merging/reviewing.

This post has been edited by Stulle: 26 November 2020 - 02:26 PM

I am an emule-web.de member and fan!

[Imagine there was a sarcasm meter right here!]

No, there will not be a new version of my mods. No, I do not want your PM. No, I am certain, use the board and quit sending PMs. No, I am not kidding, there will not be a new version of my mods just because of YOU asking for it!
1

#131 User is offline   p033928 

  • Advanced Member
  • PipPipPip
  • Group: Members
  • Posts: 77
  • Joined: 28-July 17

Posted 26 November 2020 - 03:25 PM

fox88:
about yr:
"p033928, this all was not addressed to you."

..if something is not -specifically addressed ,on a normal forum,(infact also you when you talk to me indicate my user...)
is for -all the people here-
cause all here with their individual skills and -> time <-
have helped the building of this 0.60 vers.
someone in a more polite and cheerly way
someone in a minor one...
but this is the worst/best of the world
;)

This post has been edited by p033928: 26 November 2020 - 04:45 PM

0

#132 User is offline   fox88 

  • Golden eMule
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 4747
  • Joined: 13-May 07

Posted 26 November 2020 - 03:48 PM

For double backslash issue a more consistent fix might be
	for (POSITION pos = list.GetHeadPosition(); pos != NULL;) {
		const CString &sDir(list.GetNext(pos));
		if (!::PathIsUNC(sDir))
			m_lstShared.AddTail(sDir);
	}


However, this may change later because of this FR. Network shares could be added as trees below the drive trees. In that case no filtering would be needed.

This post has been edited by fox88: 26 November 2020 - 03:59 PM

0

#133 User is offline   Stulle 

  • [Enter Mod] Dev
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 5754
  • Joined: 07-April 04

Posted 26 November 2020 - 06:58 PM

View Postfox88, on 26 November 2020 - 03:48 PM, said:

For double backslash issue a more consistent fix might be
	for (POSITION pos = list.GetHeadPosition(); pos != NULL;) {
		const CString &sDir(list.GetNext(pos));
		if (!::PathIsUNC(sDir))
			m_lstShared.AddTail(sDir);
	}


However, this may change later because of this FR. Network shares could be added as trees below the drive trees. In that case no filtering would be needed.

Could be, haven't checked. Anyhow, MorphXT has been sporting a way to share network folders for some years which relies on some Slugfiller crafted threaded lookup. Although i am beginning to wonder if I should be checking if it still works...
I am an emule-web.de member and fan!

[Imagine there was a sarcasm meter right here!]

No, there will not be a new version of my mods. No, I do not want your PM. No, I am certain, use the board and quit sending PMs. No, I am not kidding, there will not be a new version of my mods just because of YOU asking for it!
0

#134 User is offline   fox88 

  • Golden eMule
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 4747
  • Joined: 13-May 07

Posted 27 November 2020 - 04:17 PM

View PostStulle, on 26 November 2020 - 09:58 PM, said:

Although i am beginning to wonder if I should be checking if it still works...

Offtopic. :)
Minimum clean installation: unpacked .exe, config and webserver from Morph 12.7 binaries, stepped through the wizard.
A shared folder on my computer has a UNC name like \\fox\dir (created for testing; there are subdirectories, but no files).
I tried to add this UNC path, it was seen in Inactive paths, but on Apply vanished without a trace (nowhere in config folder).

For the same share in my build, it could be seen in UNC paths and in Shared Files page.

Is this normal for Morph?
0

#135 User is offline   Stulle 

  • [Enter Mod] Dev
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 5754
  • Joined: 07-April 04

Posted 27 November 2020 - 05:11 PM

View Postfox88, on 27 November 2020 - 04:17 PM, said:

Is this normal for Morph?

I should not think so. But it'll take me a while to get to the point where I can bother with functionality again. Right now my entire code base is a simple mess of semi-merged code.
I am an emule-web.de member and fan!

[Imagine there was a sarcasm meter right here!]

No, there will not be a new version of my mods. No, I do not want your PM. No, I am certain, use the board and quit sending PMs. No, I am not kidding, there will not be a new version of my mods just because of YOU asking for it!
0

#136 User is offline   Stulle 

  • [Enter Mod] Dev
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 5754
  • Joined: 07-April 04

Posted 29 November 2020 - 12:38 PM

You should provide some verbose logging with up/down events. Otherwise it's next to impossible to figure out if it's really a problem or just chance (bad luck).
I am an emule-web.de member and fan!

[Imagine there was a sarcasm meter right here!]

No, there will not be a new version of my mods. No, I do not want your PM. No, I am certain, use the board and quit sending PMs. No, I am not kidding, there will not be a new version of my mods just because of YOU asking for it!
0

#137 User is offline   fox88 

  • Golden eMule
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 4747
  • Joined: 13-May 07

Posted 30 November 2020 - 11:11 AM

Heliotropo,
there are already three deleted messages on the subject of poor upload, but none left in this topic.
In case you decide there is an issue, then first of all, it would be necessary to know the true connection bandwidth and limits, as well as other configuration details - hardware used (and maybe some other settings).
Relevant parts of statistics could be copied and pasted as text.
0

  • Member Options

  • (7 Pages)
  • +
  • « First
  • 5
  • 6
  • 7

1 User(s) are reading this topic
0 members, 1 guests, 0 anonymous users