Official eMule-Board: Emule Extended Support For Mkv - Official eMule-Board

Jump to content


Page 1 of 1

Emule Extended Support For Mkv

#1 User is offline   Xeus32 

  • Member
  • PipPip
  • Group: Members
  • Posts: 21
  • Joined: 28-May 03

Posted 12 April 2016 - 04:42 PM

Dear all,



I'm workingon a patch to add full support to Matroska (MKV -https://it.wikipedia.org/wiki/Matroska)



My baseidea was to add Mediainfo library (https://mediaarea.net) to parse the files,so i want to add some code in the function CKnownFile::UpdateMetaDataTags() that is called when the file downloadis completed.

Now, Mediainfo library is handled form CMediaInfoDLL class that is located in FileInfoDialog.cpp and ituseful only to show the file info in the Dialog.

I spokewith tHeWiZaRdOfDoS about this idea and we see different strategies to makethis job.

  • add the libdirectly to emule source as id3lib (this is my first choice)
  • dynamiclink at run time, so we can easily update the component with new versionswithout update the source code. In this second case, we need to define if wewant an auto upgrade function (download the last version of the file). The fileMediainfo.dll must be in bundle with the application
  • useMediainfo CLI and parse the xml to get the info (similar to the previous) butwithout dll handling.




what do youthink about?


0

#2 User is offline   tHeWiZaRdOfDoS 

  • Man, what a bunch of jokers...
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 5630
  • Joined: 28-December 02

Posted 13 April 2016 - 07:46 AM

Well, to repeat my arguments in public:
  • To be able to easily update mediainfo support, I'd vote for .dll. Other reason are that .dll support is already built-in and that new versions with updated mediainfo would be rather rare.
  • Auto-Update for mediainfo is already available in some clients and could be adapted. To get the most from mediainfo (kad indexing, etc.), I suggest that this feature is enabled by default
  • Moving away from ID3lib only makes sense if mediainfo usage is mandatory

0

  • Member Options

Page 1 of 1

1 User(s) are reading this topic
0 members, 1 guests, 0 anonymous users