Official eMule-Board: Emule 0.50B Beta1 Released - Official eMule-Board

Jump to content


  • (15 Pages)
  • +
  • 1
  • 2
  • 3
  • 4
  • Last »

Emule 0.50B Beta1 Released

#21 User is offline   Riso64Bit 

  • Magnificent Member
  • PipPipPipPipPipPip
  • Group: Members
  • Posts: 323
  • Joined: 24-March 09

Posted 25 March 2015 - 05:01 PM

thanks for the info Fox88!
0

#22 User is offline   fox88 

  • Golden eMule
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 4469
  • Joined: 13-May 07

Posted 25 March 2015 - 05:28 PM

On the subject of VS2013.
When converting projects for that version, several minor alterations had to be done.
The one I recall right now was name clash of CMemDC class (defined in MemDC.h) with the name in latest versions of MFC.
The problem was solved with minor refactoring: to replace CMemDC with CMemoryDC in a handful of files.

It would be nice to have such changes applied to official code.
0

#23 User is offline   Enig123 

  • Golden eMule
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 492
  • Joined: 22-November 04

Posted 25 March 2015 - 09:19 PM

In ListenSocket.cpp line 513, when we received OP_FILEREQANSNOFIL from remote client, we set not swap to our requested file. However, some buggy client will send the hash out of nowhere, the file should be set to
client->DontSwapTo(reqfile); // ZZ:DownloadManager
here instead, or we should check if our requested file is the same with the OP_FILEREQANSNOFIL answer before taking actions.

This is spotted by Xtreme mod, just reminder here.

Edit: Added modified codes as following
				case OP_FILEREQANSNOFIL:
				{
					if (thePrefs.GetDebugClientTCPLevel() > 0)
						DebugRecv("OP_FileReqAnsNoFil", client, (size >= 16) ? packet : NULL);
					theStats.AddDownDataOverheadFileRequest(size);
					if (size == 16)
					{
						CPartFile* reqfile = theApp.downloadqueue->GetFileByID(packet);
						if (!reqfile){
							client->CheckFailedFileIdReqs(packet);
							break;
						}
						/*
						else
							reqfile->m_DeadSourceList.AddDeadSource(client);
						*/

						if (!client->GetRequestFile())	//Enig123::are we requesting a downloading file?
						{
							AddDebugLogLine(false,_T("Source: (%s) answered FNF while asking for no file!(TCP)"), DbgGetClientInfo()); 
							break;
						}

						if (client->GetRequestFile()!=reqfile) //Enig123::make sure we are talking about the same file
						{
							AddDebugLogLine(false,_T("Source: (%s) answered FNF while asking for another file!(TCP)"), DbgGetClientInfo()); 
							break;
						}

						reqfile->m_DeadSourceList.AddDeadSource(client);


						// if that client does not have my file maybe has another different
						// we try to swap to another file ignoring no needed parts files
						switch (client->GetDownloadState())
						{
							case DS_CONNECTED:
							case DS_ONQUEUE:
							case DS_NONEEDEDPARTS:
								/*
								client->DontSwapTo(client->GetRequestFile()); // ZZ:DownloadManager
								*/	//Enig123::reqfile might be differant to client->GetRequestFile()
								client->DontSwapTo(reqfile); // ZZ:DownloadManager
								if (!client->SwapToAnotherFile(_T("Source says it doesn't have the file. CClientReqSocket::ProcessPacket()"), true, true, true, NULL, false, false)) { // ZZ:DownloadManager
									theApp.downloadqueue->RemoveSource(client);
								}
							break;
						}
						break;
					}
					throw GetResString(IDS_ERR_WRONGPACKAGESIZE);
					break;
				}

This post has been edited by Enig123: 27 March 2015 - 06:15 AM

0

#24 User is offline   xilolee 

  • eMule 0.50b BETA1 user
  • PipPipPipPipPipPipPip
  • Group: Italian Moderators
  • Posts: 7605
  • Joined: 20-August 08

Posted 26 March 2015 - 12:25 AM

Yahoooo! :clap:
INCONCEIVABLE! - You keep using that word. I do not think it means what you think it means.
come ottenere aiuto italian guides - guide della sezione italiana
italian support - sezione italiana scaricare la lista server
ottenere id alto impostare le porte nel router
recuperare file corrotti i filtri ip
Sembra talco ma non č serve a darti l'allegrIa! Se lo lanci e poi lo respiri ti dā subito l'allegrIa! Posted Image
0

#25 User is offline   fox88 

  • Golden eMule
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 4469
  • Joined: 13-May 07

Posted 26 March 2015 - 09:12 AM

At line 1048 in ListenSocket.cpp possibly copy & paste bug:
if (opcode == OP_REQUESTFILENAME /*low priority for OP_REQUESTFILENAME*/)
	DebugLogWarning(_T("Error: %s - while processing eDonkey packet: opcode=%s  size=%u; %s"), error, DbgGetDonkeyClientTCPOpcode(opcode), size, DbgGetClientInfo());
else
	DebugLogWarning(_T("Error: %s - while processing eDonkey packet: opcode=%s  size=%u; %s"), error, DbgGetDonkeyClientTCPOpcode(opcode), size, DbgGetClientInfo());


What it was intended to be?
0

#26 User is offline   Enig123 

  • Golden eMule
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 492
  • Joined: 22-November 04

Posted 26 March 2015 - 08:17 PM

My best guess, according to the comment, is that when opcode is OP_REQUESTFILENAME, it shall use log with less priority, AddDebugLogLine() maybe.
0

#27 User is offline   tHeWiZaRdOfDoS 

  • Man, what a bunch of jokers...
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 5630
  • Joined: 28-December 02

Posted 27 March 2015 - 09:22 AM

Repo rev28 changes should be merged to WebServer.cpp, too :angelnot:
0

#28 User is offline   nemoW 

  • Newbie
  • Pip
  • Group: Members
  • Posts: 7
  • Joined: 27-March 15

Posted 27 March 2015 - 11:04 PM

New version still allows you to set 10KB/s upload limit and download at any available speed. :thumbup:

This post has been edited by nemoW: 27 March 2015 - 11:06 PM

0

#29 User is offline   Zangune 

  • Golden eMule
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 1941
  • Joined: 05-March 12

Posted 28 March 2015 - 12:25 AM

But this should not be used unless you have a very slow connection.
0

#30 User is offline   DavidXanatos 

  • Neo Dev
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 1460
  • Joined: 23-April 04

Posted 28 March 2015 - 10:08 AM

@SS
So what about making the current emule compilable with this free VS 2013 IDE
I believe that would be a great improvement :D
Posted Image
NeoLoader is a new file sharing client, supporting ed2k/eMule, Bittorent and one click hosters,
it is the first client to be able to download form multiple networks the same file.
NL provides the first fully decentralized scalable torrent and DDL keyword search,
it implements an own novel anonymous file sharing network, providing anonymity and deniability to its users,
as well as many other new features.
It is written in C++ with Qt and is available for Windows, Linux and MacOS.
1

#31 User is offline   DavidXanatos 

  • Neo Dev
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 1460
  • Joined: 23-April 04

Posted 28 March 2015 - 07:10 PM

How about adding NeoLaoder Client recognition to the new mule?
Posted Image
NeoLoader is a new file sharing client, supporting ed2k/eMule, Bittorent and one click hosters,
it is the first client to be able to download form multiple networks the same file.
NL provides the first fully decentralized scalable torrent and DDL keyword search,
it implements an own novel anonymous file sharing network, providing anonymity and deniability to its users,
as well as many other new features.
It is written in C++ with Qt and is available for Windows, Linux and MacOS.
1

#32 User is offline   Ergol 

  • Magnificent Member
  • PipPipPipPipPipPip
  • Group: Members
  • Posts: 341
  • Joined: 07-March 03

Posted 29 March 2015 - 02:05 PM

Noted the following as per attached pic which seems like a garbled caption while searching Kad network for "better results" search entry.

Posted Image

Hope it helps.
0

#33 User is offline   Riso64Bit 

  • Magnificent Member
  • PipPipPipPipPipPip
  • Group: Members
  • Posts: 323
  • Joined: 24-March 09

Posted 01 April 2015 - 08:38 PM

new bug:

open eMule (tested whit beta1) whit autoconnect disabled, then configure eMule to have webserver and anable it.
access from webserver.now follow these steps:
1) go to kad tab in webserver and click "connect" (first problem: it remain "Connecting"). now emule is connected
01/04/2015 22.23.03: Starting Kademlia
01/04/2015 22.23.04: Read 902 source, 7496 keyword, and 86 load entries

Quote

Kad Network
Status: Open
UDP Status: Open

2) come back to kad tab and update the page , now webserver show correctly "Connected".
Now click "disconnect" (webserver show correctly "disconnected")
3) come back to emule and you can show in verborse
01/04/2015 22.26.14: Stopping Kademlia
01/04/2015 22.26.14: Wrote 189 contacts to file.
01/04/2015 22.26.14: Wrote 902 source, 7496 keyword, and 86 load entries

But in "my info tab" (in server window) show:

Quote

Kad Network
Status: Open
UDP Status: Open
IP:Port: MYIP:MYPORT
ID: MYID

and the kad arrow is Green.
if i double click on Green arrow receive
eD2K Network
Status:	Disconnected

Kad Network
Status:	Disconnected
(correctly disconnected)


Posted Image
Note: the "Connect button" is set to "Disconnect"

This post has been edited by Riso64Bit: 01 April 2015 - 08:45 PM

0

#34 User is offline   fabtar 

  • Golden eMule
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 878
  • Joined: 14-March 04

Posted 05 April 2015 - 07:08 AM

Thankyou for the new Beta, from me and my Emule-addicted father

This post has been edited by fabtar: 05 April 2015 - 07:08 AM

0

#35 User is offline   hunzhang 

  • Newbie
  • Pip
  • Group: Members
  • Posts: 6
  • Joined: 11-April 15

Posted 11 April 2015 - 11:07 AM

UPnP is broken in Windows 8.1 64bit with the 0.50B Beta1.
I'm using wireless LAN (WLAN, Router Model:TP-LINK TL-WR841N) with my desktop, but version 0.50a has a working UPnP function with exactly the same hardware and software configuration, so I think this should be a bug.
0

#36 User is offline   fox88 

  • Golden eMule
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 4469
  • Joined: 13-May 07

Posted 11 April 2015 - 11:52 AM

View Posthunzhang, on 11 April 2015 - 02:07 PM, said:

I think this should be a bug.

It might be useful to post related log lines. See an example here.
0

#37 User is offline   fox88 

  • Golden eMule
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 4469
  • Joined: 13-May 07

Posted 11 April 2015 - 12:04 PM

Code in file srchybrid\kademlia\net\KademliaUDPListener.cpp might be improved with several changes.

1. There is a possibility of memory leak in exception handling, because CKadTag* pTag would not be destroyed.
2. There is inconsistency in occasional use of uint32 to store ReadByte() result instead of uint8 (as in other places).
Since the variable is used only in loop header, for code efficiency it should be simply unsigned.
3. In some code sequences like
delete pEntry;
pEntry = NULL; //not needed
or
delete pTags;
pTags = NULL; //not needed
the second line are unnecessary when local variables would never be used after destruction.
4. Use of for() instead of while() limits scope of loop variable and keeps all loop-making in one line instead of three.

These points are applicable to several places in the file.

Below is an example based on Process_KADEMLIA2_PUBLISH_SOURCE_REQ method; all changes are marked with //*** comments
Spoiler

This post has been edited by fox88: 28 June 2015 - 06:26 PM

0

#38 User is offline   hunzhang 

  • Newbie
  • Pip
  • Group: Members
  • Posts: 6
  • Joined: 11-April 15

Posted 11 April 2015 - 12:42 PM

View Postfox88, on 11 April 2015 - 07:52 PM, said:

View Posthunzhang, on 11 April 2015 - 02:07 PM, said:

I think this should be a bug.

It might be useful to post related log lines. See an example here.


Here is the log:
2015/4/11 20:39:54: Found 6 known shared files, going to hash 1 new files
2015/4/11 20:39:54: Credit file loaded, 803 clients are known
2015/4/11 20:39:54: Trying to setup port forwardings with UPnP...
2015/4/11 20:39:54: Hashing file: "E:\eMule0.50b_BETA1\Incoming\eMule0.50b.15 Beta Testfile 0b2449.txt"
2015/4/11 20:39:55: 0 servers in server.met found
2015/4/11 20:39:55: Found 1 part files
2015/4/11 20:39:55: eMule Version 0.50b BETA1 ready
2015/4/11 20:39:56: Read 200 contacts from file.
2015/4/11 20:40:12: UPnP failed to setup port forwardings, please foward those ports manually if necessary!
2015/4/11 20:40:13: UploadSpeedSense: Done with preparations. Starting control of upload speed. (First 60 seconds will be in fast reaction mode)
0

#39 User is offline   fox88 

  • Golden eMule
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 4469
  • Joined: 13-May 07

Posted 11 April 2015 - 02:58 PM

hunzhang,
the example was about verbose log, because ordinary log is uninformative - we already heard that UPnP failed.
Also it might be interesting to give logs from both 0.50a and 0.50b beta1.
0

#40 User is offline   Zangune 

  • Golden eMule
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 1941
  • Joined: 05-March 12

Posted 11 April 2015 - 03:50 PM

To enable verbose log Options - Extended tick Enabled in "Verbose (additional program feedback)", output will be in Servers - Verbose.
0

  • Member Options

  • (15 Pages)
  • +
  • 1
  • 2
  • 3
  • 4
  • Last »

5 User(s) are reading this topic
0 members, 5 guests, 0 anonymous users