Official eMule-Board: Update Smirc - Official eMule-Board

Jump to content


Page 1 of 1

Update Smirc eMule IRC code Rate Topic: -----

#1 User is offline   Zangune 

  • Golden eMule
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 1941
  • Joined: 05-March 12

Posted 27 February 2014 - 05:27 PM

I will edit this post and add pictures.

eMule IRC code can be improved.

01 - On Status and Channels tab close should be disabled, like in eMulePlus;
02 - On channel eMule strips colors, it shouldn't, like in eMulePlus;
03 - If you are not in #Channel and type /mode #Channel a new tab titled #Channel will open, but you cannot close it, it should give channel modes information only, like it is a notice message or so;
04 - /whois is showed in Status tab, it should be shown in actual tab except if you are in Channels tab;
05 - /ison gives no results if nicks are not on the actual network and is in Status tab, it is right as you can read here, but it is confusing, too. It should give results in actual tab and the answer should be something like in KVIrc YourNick: FoundNickList;
06 - /part should close actual tab, it requires #channel for now, it should be semplified;
07 - Add Voice, DeVoice, HalfOp, DeHalfOp, Op, DeOp, Protect, DeProtect, Owner, DeOwner and WhoIs on contextual menu, like in eMule Plus;
08 - Remove slap message on contextual menu;
09 - Hide Ping?Pong! in Status tab, it should be better if this can be managed in Options - IRC or so;
10 - Signon time not in Unix timestamp, but a readable date and time, like eMulePlus.
11 - [+], [%], [@], [&] and [~] characters should appear in channel log, too, like mIRC.
12 - Join a channel, join the same channel by using a clone, open a private conversation with your clone, change the clone's nick, private conversation tab title is the new nick, as it should be, but in the channel you will read the old nick, something similar here.

Posted Image
Posted Image

eMulePlus isn't affected by this problem;

13 - Open a channel doubleclick on your nick to open a private conversation, it doesn't work, you just get a message that states the private conversation is started, but is false

Posted Image

14 - Join the network with a clone, one of the two users clicks on List, the second sends a notice to the first, a new tab is open, that shouldn't happen (trivial).

Posted Image

15 - Join a channel, join another channel with a clone, send a message to the first eMule, if you misspell the nick notice message is sent to Status tab, some CompareNoCase missed?

Posted Image

16 - Options - IRC - Nick, maximum nick length is 20, but if you choose a 20 characters nick and you click Apply eMule truncates to 19 characters, eMule should not or nick maximum length should be 19. Trivial.
17 - Do not close IRC windows on kick, feature request by Achab
18 - eMule changelog Oct, 15. 2005

Quote

Ornis: systray flashes with message icon on incoming new message (message, not IRC (yet))

It can be added now.
19 - Add support for /helpop;
20 - If an HalfOp tries to set N mode the server replies he can't, but smirc doesn't show the message, this problem is probably extended to other kind of messages.
21 - Away reply should appear in current tab, not Status tab;
22 - If you have a connection problem and you lose connection then all tabs will be closed, it is annoying and it would be better if tabs will be closed if you click 'Disconnect' only.
23 - Tab completition is too much simplified, if I wrote one or more characters of a nick and press tab button it finds first occurrence of that nick only, but it would be better if a second tab pressure will find second occurrence and so in a cyclic way, like mIRC.
24 - If I wrote more than one word without pressing Send button and I try to tripleclick to select all words eMule selects last word only, it should select all words like in Search - Name. Trivial but very easy to fix, I guess.
25 - Tab text color in blue and another icon if someone wrote your nick, and keep it in blue if someone wrote something else, of course.
26 - Log text in dark blue if someone wrote your nick.
27 - Echo of the message of someone that wrote your nick.
28 - IrcNickListCtrl.cpp Line 117

	menuNick.AppendMenu(MF_STRING, Irc_Ban, _T("Ban"));
	//Ban currently uses chanserv to ban which seems to kick also.. May change this later..
	//	menuNick.AppendMenu(MF_STRING, Irc_KB, _T("Kick/Ban"));

/mode #Channel b Ident@

may be better, ChanServ is from @ upwards, b mode is from % upwards, at least in MindForge default channel configuration.
29 - There is no reason to keep Channels tab always open, add close button.
30 - If a smile is in a channel topic and you use that smile then this smile is included in a black box, this should be related to a trasparency issue because the topic background is usually black and the log background is usually white. This problem disappear after some log lines. Trivial.
31- If you join a channel and an users has two channel status like % and + and the higher status is removed, in this case %, eMule ignores the second channel status, in this case +.
32- 'Reset all previous formatting (sends a reset tag)' button doesn't reset background, just the text color.
33- \eMule0.50a-Sources\srchybrid\lang line 1645 "Should be one word less than 20 characters containing (A-Z, 0-9). It can be changed again in Options->IRC." is false or confusing: ]nick is a valid nick, 0nick is not a valid nick and in eMule maximum nick lenght is 19 (read above) but MindForge accepts 30 characters nick leght.
34- the client is not fully UTF-8 capable, to test that register a nickname (/ns register password email), set MemoServ to send you the memo to your email address, too (/ms set notify mail), send to you a memo with accented characters (/ms send nick èéòàù) and check the email.

Help me to improve this list.

This post has been edited by Zangune: 06 December 2015 - 09:05 PM

0

#2 User is offline   fox88 

  • Golden eMule
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 4747
  • Joined: 13-May 07

Posted 16 March 2014 - 08:57 AM

eMule IRC code can be improved.
It could be; but what is the goal?
eMule is a file sharing program. It has limited IRC client added only as a tool to get technical help.
If you need full-featured client, use something else.

On Status and Channel tab close should be disabled, like in eMulePlus;
Currently there is no way to close Status or Channels tabs.
#Channel tab should not close automatically when user gets kicked. It was discussed already, and probably fixed; was it not?

On channel eMule strips colors, it shouldn't, like in eMulePlus;
It is not eMule. Ask ops.

/ison gives no results
There are many other IRC messages which are not processed. No DCC. No CTCP. No programming.
The reasons were explained in the beginning.

/part should close actual tab, it requires #channel for now, it should be semplified;
Probably.
But will a casual help channel visitor know about /part command at all?
There is useful red button on channel's tab and Close button below nick list.

Add Voice, DeVoice, HalfOp, DeHalfOp, Op, DeOp, Protect, DeProtect, Owner, DeOwner and WhoIs on contextual menu, like in eMule Plus;
Why add a whole bunch of rarely used commands?
I guess it could be discussed when eMule Plus gets KAD support. :P
Thought WhoIs could be useful.

Remove slap message on contextual menu;
It's a tradition. Why bother?

Signon time not in Unix timestamp, but a readable date and time, like eMulePlus.
I disliked that too; even fixed for myself.

This post has been edited by fox88: 16 March 2014 - 08:59 AM

0

#3 User is offline   Zangune 

  • Golden eMule
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 1941
  • Joined: 05-March 12

Posted 16 March 2014 - 12:54 PM

Hey fox88, use [quote] please!

View Postfox88, on 16 March 2014 - 09:57 AM, said:

eMule is a file sharing program. It has limited IRC client added only as a tool to get technical help.
If you need full-featured client, use something else.

I agree, but a bug is still a bug and a improvement is still an improvement, isn't that true?

View Postfox88, on 16 March 2014 - 09:57 AM, said:

Currently there is no way to close Status or Channels tabs.

Yes, but the button is still active.
My post is not complete, really sorry. I am facing an hardware failure on my pc, I am not actually using my pc.
EDIT: Screenshot here

Posted Image

View Postfox88, on 16 March 2014 - 09:57 AM, said:

#Channel tab should not close automatically when user gets kicked. It was discussed already, and probably fixed; was it not?

Sadly no, read above.

View Postfox88, on 16 March 2014 - 09:57 AM, said:

On channel eMule strips colors, it shouldn't, like in eMulePlus;
It is not eMule. Ask ops.

It' eMule, again a screenshot is needed there. For now trust me, please. I verified that.
EDIT Screenshot here

Posted Image
Posted Image

View Postfox88, on 16 March 2014 - 09:57 AM, said:

/ison gives no results
There are many other IRC messages which are not processed. No DCC. No CTCP. No programming.
The reasons were explained in the beginning.

That fix should be really really easy to implement and again, it's an improvement.

View Postfox88, on 16 March 2014 - 09:57 AM, said:

/part should close actual tab, it requires #channel for now, it should be semplified;
Probably.
But will a casual help channel visitor know about /part command at all?
There is useful red button on channel's tab and Close button below nick list.

Read above.

View Postfox88, on 16 March 2014 - 09:57 AM, said:

Add Voice, DeVoice, HalfOp, DeHalfOp, Op, DeOp, Protect, DeProtect, Owner, DeOwner and WhoIs on contextual menu, like in eMule Plus;
Why add a whole bunch of rarely used commands?

Read above.

View Postfox88, on 16 March 2014 - 09:57 AM, said:

I guess it could be discussed when eMule Plus gets KAD support. :P

Can't understand.

View Postfox88, on 16 March 2014 - 09:57 AM, said:

Remove slap message on contextual menu;
It's a tradition. Why bother?

People try this command and get kicked.

View Postfox88, on 16 March 2014 - 09:57 AM, said:

Signon time not in Unix timestamp, but a readable date and time, like eMulePlus.
I disliked that too; even fixed for myself.

Can you post that fix, please?

Read first post.

This post has been edited by Zangune: 31 March 2014 - 10:47 AM

0

#4 User is offline   Eulero 

  • Golden eMule
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 2553
  • Joined: 09-August 07

Posted 23 March 2014 - 08:35 AM

View PostZangune, on 16 March 2014 - 01:54 PM, said:

People try this command and get kicked.


only in #emule-it channel. Posted Image
0

#5 User is offline   fox88 

  • Golden eMule
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 4747
  • Joined: 13-May 07

Posted 23 March 2014 - 02:20 PM

View PostEulero, on 23 March 2014 - 11:35 AM, said:

only in #emule-it channel.

In English too, though you would be warned first by ops to stop abusing the feature.

This post has been edited by fox88: 17 April 2019 - 02:09 PM

0

#6 User is offline   Sir_Boagalott 

  • Golden eMule
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 466
  • Joined: 23-September 02

Posted 19 May 2014 - 07:42 AM

I have wanted the irc updated for years, good luck, seriously. :flowers:

Unfortunately there has been practically 0 Modders willing to advance the irc. Everybody just wants to code the p2p part.

Why update the irc at all though? When it could be completely replaced with a way more functional open source C++ XMPP client. :angelnot:
0

#7 User is offline   Zangune 

  • Golden eMule
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 1941
  • Joined: 05-March 12

Posted 19 May 2014 - 09:44 AM

View PostSir_Boagalott, on 19 May 2014 - 09:42 AM, said:

I have wanted the irc updated for years, good luck, seriously. :flowers:

Thank you :)

View PostSir_Boagalott, on 19 May 2014 - 09:42 AM, said:

Unfortunately there has been practically 0 Modders willing to advance the irc. Everybody just wants to code the p2p part.

Saldly I found no mod with an updated IRC part, if someone knows about a mod with a bugfixed IRC part please let me know.

View PostSir_Boagalott, on 19 May 2014 - 09:42 AM, said:

Why update the irc at all though? When it could be completely replaced with a way more functional open source C++ XMPP client. :angelnot:

We have to be realistic: nobody will rewrite eMule, no major changes at all. We can only hope in small and smart changes.
These are small, at least!
0

#8 User is offline   Sir_Boagalott 

  • Golden eMule
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 466
  • Joined: 23-September 02

Posted 19 May 2014 - 08:14 PM

Quote

We have to be realistic: nobody will rewrite eMule, no major changes at all. We can only hope in small and smart changes.
These are small, at least!


It wouldnt take a rewrite though. I dont think it would be a major code change either. Sure it would be work, but I dont think it would be a huge ordeal to remove the irc (most mods have) and add xmpp. The majority of the work would be redoing the xmpp gui to have it run inside eMule.

The increased functionality of the chat would be insane.
0

#9 User is offline   Zangune 

  • Golden eMule
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 1941
  • Joined: 05-March 12

Posted 20 May 2014 - 09:25 AM

View PostSir_Boagalott, on 19 May 2014 - 10:14 PM, said:

The increased functionality of the chat would be insane.

In example?
0

#10 User is offline   Sir_Boagalott 

  • Golden eMule
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 466
  • Joined: 23-September 02

Posted 20 May 2014 - 11:00 AM

I guess you do not recognize the term XMPP? xmpp clients are full featured multi platform - msn, yahoo, icq etc - some can do video chat. Most of the big closed source 3rd party chat apps are xmpp clients. ex Trillian

Google: open source xmpp c++

Theres several.
0

#11 User is offline   Remorseless 

  • Newbie
  • Pip
  • Group: Members
  • Posts: 1
  • Joined: 09-January 19

Posted 17 April 2019 - 11:52 AM

View PostSir_Boagalott, on 19 May 2014 - 07:42 AM, said:

I have wanted the irc updated for years, good luck, seriously. :flowers:

Unfortunately there has been practically 0 Modders willing to advance the irc. Everybody just wants to code the p2p part.

Why update the irc at all though? When it could be completely replaced with a way more functional open source C++ XMPP client. :angelnot:


Thanks :)
0

  • Member Options

Page 1 of 1

1 User(s) are reading this topic
0 members, 1 guests, 0 anonymous users