Official eMule-Board: Current Source Code - Official eMule-Board

Jump to content


  • (27 Pages)
  • +
  • 1
  • 2
  • 3
  • 4
  • 5
  • Last »

Current Source Code

#41 User is offline   Some Support 

  • Last eMule
  • PipPipPipPipPipPipPip
  • Group: Yes
  • Posts: 3649
  • Joined: 27-June 03

Posted 11 August 2013 - 09:57 PM

View PostEnig123, on 11 August 2013 - 09:49 PM, said:

Does the crashes related to the NULL pUpClientStruct within CUpDownClient::DrawUpStatusBar() which also invoked by queuelistctrl?

Yes.

Quote

Also with the change of definision of uploadinglist,
bool	IsDownloading(CUpDownClient* client)	const {return (uploadinglist.Find(client) != 0);}

does not work as it should anymore.

Whee, indeed. Good point, thanks :) It seems Find() is not a part member of the CTypedPtrList wrapper and therefore doesn't checks for proper types -> no compiler warning.


Quote

That reminds me of how does it happened anyway. How can we prevent duplicate client pointer in the waitinglist in the first place? As I checked, the routine CUploadQueue::RemoveFromUploadQueue() does have dupcheck by its own.

The code logic makes sure of it, it will never try to add an already downloading client - obviously that broke with the IsDownloading function.

Quote

I think something could be tweaked in SVN: all the files in .zip get the same date/time; apparently time of .zip creation.
While the expected behaviour was to have the last modification time for each file.

If you mean the snapshot function on the mercurial repository then I doubt I can change much there, its running on SF servers after all (well actually I am not sure how much control I do have over those services, didn't used SF for much else than downloading and project page).

#42 User is offline   fox88 

  • Golden eMule
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 4712
  • Joined: 13-May 07

Posted 12 August 2013 - 04:00 AM

Dump

PS.

View PostSome Support, on 12 August 2013 - 12:57 AM, said:

If you mean the snapshot function on the mercurial repository then I doubt I can change much there

I went to mercurial IRC channel and asked. People said that this is how it works; there is no such setting.
A bit of surprise.

This post has been edited by fox88: 12 August 2013 - 06:01 PM

0

#43 User is offline   Riso64Bit 

  • Magnificent Member
  • PipPipPipPipPipPip
  • Group: Members
  • Posts: 336
  • Joined: 24-March 09

Posted 12 August 2013 - 01:10 PM

whit beta 6DevBuild under windows 7 when i try to show (in Download tab) all sources for a file in download, the render of this list is very slow.

PS. in this version the UPLOAD work fine (i can upload data to other clients)


Crash when my upload's slots are FULL. emule try to push clients in queue & if i click on "queue tab" emule crash.
crash 1:
http://temp-share.com/show/2gFbKrZx8


i can regenerate the problem:
crash 2:
http://temp-share.com/show/FHK4P7806

(emule crash ONLY when i click on "Queue list"'s button)

This post has been edited by Riso64Bit: 12 August 2013 - 07:41 PM

0

#44 User is offline   xilolee 

  • eMule 0.50b BETA1 user
  • PipPipPipPipPipPipPip
  • Group: Italian Moderators
  • Posts: 7907
  • Joined: 20-August 08

Posted 13 August 2013 - 02:13 PM

View PostSome Support, on 11 August 2013 - 09:50 PM, said:

View Postxilolee, on 11 August 2013 - 06:48 PM, said:

The server issue is present yet...
Uhm... This time I had four crashes when I was in the transfers - on queue list

eMule_0-50b-6_20130811-194817.dmp
eMule_0-50b-6_20130811-195715.dmp
eMule_0-50b-6_20130811-204243.dmp

On queue list disabled, crashes disappeared.


Yes that's a crash related to the dev branch changes, will be fixed.

INCONCEIVABLE! - You keep using that word. I do not think it means what you think it means.
come ottenere aiuto italian guides - guide della sezione italiana
italian support - sezione italiana scaricare la lista server
ottenere id alto impostare le porte nel router
recuperare file corrotti i filtri ip
Sembra talco ma non č serve a darti l'allegrIa! Se lo lanci e poi lo respiri ti dā subito l'allegrIa! Immagine Postata
0

#45 User is offline   Some Support 

  • Last eMule
  • PipPipPipPipPipPipPip
  • Group: Yes
  • Posts: 3649
  • Joined: 27-June 03

Posted 16 August 2013 - 09:17 AM

The upload problem on XP should be fixed now. It wasn't actually XP specific but a bug in the code which appears to show on this windows version mainly. Anyway should work better now. During the tests I had uploadrates of over 100MBits (file was finished then, so it stopped there) - so I'm pretty confident that any upload speed problems with bigger lines will be gone in 0.50b.

#46 User is offline   xilolee 

  • eMule 0.50b BETA1 user
  • PipPipPipPipPipPipPip
  • Group: Italian Moderators
  • Posts: 7907
  • Joined: 20-August 08

Posted 16 August 2013 - 02:35 PM

No more problems with on queue list! :+1:

(I don't remembrer if it has been already posted) In Windows 8, left-clicking every split bar (and drag it) causes this:

Posted Image

This post has been edited by xilolee: 16 August 2013 - 02:46 PM

INCONCEIVABLE! - You keep using that word. I do not think it means what you think it means.
come ottenere aiuto italian guides - guide della sezione italiana
italian support - sezione italiana scaricare la lista server
ottenere id alto impostare le porte nel router
recuperare file corrotti i filtri ip
Sembra talco ma non č serve a darti l'allegrIa! Se lo lanci e poi lo respiri ti dā subito l'allegrIa! Immagine Postata
0

#47 User is offline   fox88 

  • Golden eMule
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 4712
  • Joined: 13-May 07

Posted 16 August 2013 - 05:07 PM

What about my crash?
The first dump is above, another is here.
The same heap free, but called from different place in code.
0

#48 User is offline   Some Support 

  • Last eMule
  • PipPipPipPipPipPipPip
  • Group: Yes
  • Posts: 3649
  • Joined: 27-June 03

Posted 16 August 2013 - 05:38 PM

View Postfox88, on 16 August 2013 - 06:07 PM, said:

What about my crash?
The first dump is above, another is here.
The same heap free, but called from different place in code.


Try the build .7, it fixed common crash errors with the new code and most likely the one you saw too. I forgot to save the symbols so I cant check (I think I looked into your dump before however but not sure), but because one of those errors would have lead to a double free and possibly corrupt the heap, it's better to retry with this error fixed and repost a new dump if it is indeed another bug.

#49 User is offline   fox88 

  • Golden eMule
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 4712
  • Joined: 13-May 07

Posted 16 August 2013 - 06:39 PM

View PostSome Support, on 16 August 2013 - 08:38 PM, said:

I forgot to save the symbols so I cant check

That could be another reason to supply .pdb :)

View PostSome Support, on 16 August 2013 - 08:38 PM, said:

it's better to retry with this error fixed and repost a new dump if it is indeed another bug.

Got it. Though it's a matter of run and wait: emule runs normally, then after several hours crashed.
But there were no crashes in last three days in decently long sessions.

Server connection bug is still not fixed, it's ugly but ccould wait.

Another strange issue: "Failed to save AICH hash" shortly after eMule loads. Obviuously it's about the special beta's file.
The failure was understandable after crash, but today it happened after careful disconnect and close.
Though this time the message did not appear again after eMule's restart, while previously it was stable and I had to use EFS's known.met file repair.

This post has been edited by fox88: 16 August 2013 - 06:41 PM

0

#50 User is offline   fox88 

  • Golden eMule
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 4712
  • Joined: 13-May 07

Posted 16 August 2013 - 08:38 PM

Crach dump.
0

#51 User is offline   Some Support 

  • Last eMule
  • PipPipPipPipPipPipPip
  • Group: Yes
  • Posts: 3649
  • Joined: 27-June 03

Posted 17 August 2013 - 08:34 AM

Thanks. It looks like a problem with the overlapped sockets, but I am not sure yet where the bug is. Please keep posting dumps if they reappear. Oh and I will provide the pdbs later when I find some time.

#52 User is offline   Zangune 

  • Golden eMule
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 1941
  • Joined: 05-March 12

Posted 17 August 2013 - 11:14 AM

Small bug in the tooltip when minimized, v0.50.1.7

Posted Image

Uploading errors fixed in Windows XP as far as I can see.
No more crashes.
0

#53 User is offline   fox88 

  • Golden eMule
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 4712
  • Joined: 13-May 07

Posted 17 August 2013 - 02:33 PM

Download overhead is not in the tooltip here too.

Another crash.
0

#54 User is offline   Enig123 

  • Golden eMule
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 518
  • Joined: 22-November 04

Posted 17 August 2013 - 05:16 PM

View PostSome Support, on 17 August 2013 - 01:34 AM, said:

Thanks. It looks like a problem with the overlapped sockets, but I am not sure yet where the bug is. Please keep posting dumps if they reappear. Oh and I will provide the pdbs later when I find some time.


It seems that the new overlapped sockets does not work well with slot focus feature so far. Namely it is not enough to keep the standby clients alive in the uploadinglist.
0

#55 User is offline   Enig123 

  • Golden eMule
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 518
  • Joined: 22-November 04

Posted 17 August 2013 - 05:18 PM

Also in CKademliaUDPListener::Process_KADEMLIA2_RES
	// Verify that the search is still active and contains no more than the requested numbers of contacts
	if (uNumContacts > CSearchManager::GetExpectedResponseContactCount(uTarget))
	{
		if (CSearchManager::GetExpectedResponseContactCount(uTarget) == 0)
			DebugLogWarning(_T("Kad: KADEMLIA2_RES: Search already expired, ignoring answer (sender: %s)"), ipstr(ntohl(uIP)));
		else
			DebugLogWarning(_T("Kad: KADEMLIA2_RES: Contact sent more nodes (%u) than requested (%u), ignoring answer (sender: %s)")
				, uNumContacts, CSearchManager::GetExpectedResponseContactCount(uTarget), ipstr(ntohl(uIP)));
		return;  //<<=== shouldn't here a return to let the detection take effect?
	}

shouldn't hhere a return to let the detection take effect?
0

#56 User is offline   Some Support 

  • Last eMule
  • PipPipPipPipPipPipPip
  • Group: Yes
  • Posts: 3649
  • Joined: 27-June 03

Posted 17 August 2013 - 05:34 PM

View PostEnig123, on 17 August 2013 - 06:16 PM, said:

It seems that the new overlapped sockets does not work well with slot focus feature so far. Namely it is not enough to keep the standby clients alive in the uploadinglist.

Well slotfocus is not in the official client so this would have to be fixed by those who use it, but in theory it should behave just like the old sockets. In any case I will recheck and test the socket code at some point. As pointed out in the first post, not everything is tested under all possible circumstances yet in the dev branch - its not a "finished" beta. For now those crashes have priority.

View PostEnig123, on 17 August 2013 - 06:18 PM, said:

Also in CKademliaUDPListener::Process_KADEMLIA2_RES
	// Verify that the search is still active and contains no more than the requested numbers of contacts
	if (uNumContacts > CSearchManager::GetExpectedResponseContactCount(uTarget))
	{
		if (CSearchManager::GetExpectedResponseContactCount(uTarget) == 0)
			DebugLogWarning(_T("Kad: KADEMLIA2_RES: Search already expired, ignoring answer (sender: %s)"), ipstr(ntohl(uIP)));
		else
			DebugLogWarning(_T("Kad: KADEMLIA2_RES: Contact sent more nodes (%u) than requested (%u), ignoring answer (sender: %s)")
				, uNumContacts, CSearchManager::GetExpectedResponseContactCount(uTarget), ipstr(ntohl(uIP)));
		return;  //<<=== shouldn't here a return to let the detection take effect?
	}

shouldn't hhere a return to let the detection take effect?

Yes :-k

#57 User is offline   Neoo26 

  • Splendid Member
  • PipPipPipPip
  • Group: Members
  • Posts: 126
  • Joined: 30-September 12

Posted 17 August 2013 - 06:06 PM

@Some Support: Will you add the NeoLoader "detection" fur final version ? :flowers:
1

#58 User is offline   Tuxman 

  • lizzie and prog-rock fanatic
  • PipPipPipPipPipPipPip
  • Group: Validating
  • Posts: 2707
  • Joined: 26-July 04

Posted 17 August 2013 - 06:08 PM

As if the three recurring NeoLoader users were worth that effort.
[ eMule beba ] :: v2.72 released, v3.00 in the works ...
- feel the lightweight! - featuring Snarl support, the Client Analyzer and tits!
Coded by a Golden eMule Award winner and most people's favorite modder!
..........................................
Music, not muzak:
Progressive Rock :: my last.fm profile
..........................................
eMule user since 0.28 ...
-[ ... and thanks for all the fish! ]-
-1

#59 User is offline   Neoo26 

  • Splendid Member
  • PipPipPipPip
  • Group: Members
  • Posts: 126
  • Joined: 30-September 12

Posted 18 August 2013 - 07:16 AM

We are minimum 4 :P

Btw I'm just asking because it probably will be the last eMule version, at least for 5-6 years. In 5-6 years NeoLoader could have a bit more users...
0

#60 User is offline   DavidXanatos 

  • Neo Dev
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 1467
  • Joined: 23-April 04

Posted 18 August 2013 - 07:24 AM

Well, eMule even has detection for lphant, so it would only be fair to also add detection for NeoLoader.

David X.
NeoLoader is a new file sharing client, supporting ed2k/eMule, Bittorent and one click hosters,
it is the first client to be able to download form multiple networks the same file.
NL provides the first fully decentralized scalable torrent and DDL keyword search,
it implements an own novel anonymous file sharing network, providing anonymity and deniability to its users,
as well as many other new features.
It is written in C++ with Qt and is available for Windows, Linux and MacOS.
0

  • Member Options

  • (27 Pages)
  • +
  • 1
  • 2
  • 3
  • 4
  • 5
  • Last »

1 User(s) are reading this topic
0 members, 1 guests, 0 anonymous users