Official eMule-Board: A Small Bug Fix In Otherfunctions.cpp - Official eMule-Board

Jump to content


Page 1 of 1

A Small Bug Fix In Otherfunctions.cpp

#1 User is offline   Avi-3k 

  • hebMule [retired] dev
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 1127
  • Joined: 25-June 03

Posted 05 March 2010 - 11:13 PM

in GetFileTypeEx() the variable extLC was suppose to be lower case (LC)
but it's given upper case, so multivalues rars aren't detected:
...
	if (   extLC.GetLength() == 3
		&& extLC.GetAt(0) == _T('R') // Avi3k: fix case
...

(one might consider changing the var to extUC, so it won't be confusing...)

also, in IsExtensionTypeOf(), the variable fext might need to be verified as upper case
otherwise the function might not work properly (since searching is done with upper case strings)
edit: haven't check this one, just guessing :P

Avi3k

This post has been edited by Avi-3k: 05 March 2010 - 11:14 PM

retired developer of hebMule and eMule Skinner...
hebMule site and topic.
hebMule2 unique features: AntiLeech, AntiVirus, Fake Check, ServerFilter, WebSearches, Export Searches, Relative Priority, ModID and much much more...

eMule Skinner is an application to create/edit skins for eMule,
it's multilingual, supports mods, easy-to-use design, integrates to hebMule & Windows and lots more...

code fixes/improvements: #1, #2, #3, #4, #5, #6, #7, #8, #9, #10, #11 (to check/verify: #12, #13).
0

#2 User is offline   Some Support 

  • Last eMule
  • PipPipPipPipPipPipPip
  • Group: Yes
  • Posts: 3649
  • Joined: 27-June 03

Posted 06 March 2010 - 11:56 AM

Thanks :)

#3 User is offline   Avi-3k 

  • hebMule [retired] dev
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 1127
  • Joined: 25-June 03

Posted 12 March 2010 - 10:51 PM

btw, found a small mistake in GetFileTypeEx() (@otherfunctions.cpp),
in line 3801 (in 0.50a-beta1) the second headerbuf = should be removed.

and in GetDRM() (@otherfunctions.cpp), the line fd = -1; is redundant (it's not used after the file is closed)

btw, was extLC already fixed before my post? nothing is written in the beta's changelog...

Avi3k

This post has been edited by Avi-3k: 12 March 2010 - 10:52 PM

retired developer of hebMule and eMule Skinner...
hebMule site and topic.
hebMule2 unique features: AntiLeech, AntiVirus, Fake Check, ServerFilter, WebSearches, Export Searches, Relative Priority, ModID and much much more...

eMule Skinner is an application to create/edit skins for eMule,
it's multilingual, supports mods, easy-to-use design, integrates to hebMule & Windows and lots more...

code fixes/improvements: #1, #2, #3, #4, #5, #6, #7, #8, #9, #10, #11 (to check/verify: #12, #13).
0

#4 User is offline   Some Support 

  • Last eMule
  • PipPipPipPipPipPipPip
  • Group: Yes
  • Posts: 3649
  • Joined: 27-June 03

Posted 12 March 2010 - 11:22 PM

Quote

btw, was extLC already fixed before my post? nothing is written in the beta's changelog...

No it was fixed because of your finding. Some changes are too small to make an entry about it and that is really such a case. Tho if it is important to you i could add it to the release changelog.

#5 User is offline   Avi-3k 

  • hebMule [retired] dev
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 1127
  • Joined: 25-June 03

Posted 13 March 2010 - 03:32 PM

that's not necessary, thanks anyway :flowers:
(though renaming the variable would be nice)

Avi3k
retired developer of hebMule and eMule Skinner...
hebMule site and topic.
hebMule2 unique features: AntiLeech, AntiVirus, Fake Check, ServerFilter, WebSearches, Export Searches, Relative Priority, ModID and much much more...

eMule Skinner is an application to create/edit skins for eMule,
it's multilingual, supports mods, easy-to-use design, integrates to hebMule & Windows and lots more...

code fixes/improvements: #1, #2, #3, #4, #5, #6, #7, #8, #9, #10, #11 (to check/verify: #12, #13).
0

  • Member Options

Page 1 of 1

1 User(s) are reading this topic
0 members, 1 guests, 0 anonymous users