[JustusJonas]

we have in DownloadClient.cpp line 326:

  UpdateDisplayedInfo(true);
  theApp.emuledlg->transferwnd.clientlistctrl.RefreshClient(this);

but here look at

void CUpDownClient::UpdateDisplayedInfo(boolean force) {
    DWORD curTick = ::GetTickCount();

    if(force || curTick-m_lastRefreshedDLDisplay > MINWAIT_BEFORE_DLDISPLAY_WINDOWUPDATE+(uint32)(rand()/(RAND_MAX/1000))) {
     theApp.emuledlg->transferwnd.downloadlistctrl.UpdateItem(this);
  theApp.emuledlg->transferwnd.clientlistctrl.RefreshClient(this);
        m_lastRefreshedDLDisplay = curTick;
    }
}

so isn't the clientlist updated twice?

This post has been edited by JustusJonas: 18 March 2003 - 07:29 PM

[LoneStar]

Potentially yes, but only if the last time the control was refreshed is longer than the formula given there. Otherwise it's only refreshed once.
-D

[zz]

Yes, someone must have forgotten to uncomment the old update call. Easy to miss.

/zz

[JustusJonas]

isn't it a whole mess with these update and refresh functions... sometimes they are directly updated, sometimes only if needed via a checking function..... how about cleaning that up? storing some info when what was updated last and only update if it is needed and only if it is seen... though i haven't looked that much into the code but i can't see any kind of structure behind updating controls...


@LoneStar nope it's forced so it's always updated twice... and i have some severe CPU suage since i upgraded to 27a... (not that this would cause it )

This post has been edited by JustusJonas: 18 March 2003 - 07:32 PM

[LoneStar]

Oh yeah, missed the force... my bad