[wader]

roversr13: this looks to be exactly what I need for importing "stuck" Azureus/BitTorrent downloads into eMule for completion when they appear to be the same file.

Q: I run eMule v.46a and your documentation notes that the latest mod was based on v.45b. Can I use rel. 3 with my current eMule version?

Thanks,

- wader

This post has been edited by wader: 23 May 2005 - 07:07 AM

[roversr13]

Of course - it is a separate exe file. Just close your main eMule, run modded exe, do the import and then close it and run 0.46a again.

This post has been edited by roversr13: 24 May 2005 - 12:28 PM

[wader]

Although it caused eMule to put up the initial configuration wizard (which I simply cancelled), your suggestion worked perfectly - as did the import.

Very useful function, thank you.

- wader

[roversr13]

Yes, wizard appears everytime you switch versions. Just canceling it, as you did, is all that need to be done.

[tHeWiZaRdOfDoS]

Still working on it? I just checked the code today for the first time (lol) as I want to write an import/export feature myself (interested?)

However:

Quote

uchar* partData = new uchar[PARTSIZE];
...
delete partData;

Is wrong! delete[] partData; should be used
GreetZ,
WiZaRd

This post has been edited by tHeWiZaRdOfDoS: 29 July 2005 - 05:53 PM

[slowsilver]

I came across something that seemed weird using 003 last night and this morning.

Imported parts from a partial 230MB BT download into a new ed2k download. The BT download was 53% done.

It managed to salvage about 25MB of the file that was slightly below my hopes, but still within reasonable expectations.

29.07.2005 21:38:34: AICH successfully recovered 0 Bytes of 9.28 MB from part 8 for file.avi
29.07.2005 21:38:39: AICH successfully recovered 0 Bytes of 9.28 MB from part 10 for file.avi
29.07.2005 21:38:42: AICH successfully recovered 180.00 KB of 9.28 MB from part 9 for file.avi
29.07.2005 21:38:42: AICH successfully recovered 0 Bytes of 9.28 MB from part 12 for file.avi
29.07.2005 21:38:51: AICH successfully recovered 1.41 MB of 9.28 MB from part 16 for file.avi
29.07.2005 21:38:52: AICH successfully recovered 0 Bytes of 9.28 MB from part 11 for file.avi
29.07.2005 21:38:53: AICH successfully recovered 0 Bytes of 9.28 MB from part 17 for file.avi
29.07.2005 21:38:54: AICH successfully recovered 0 Bytes of 9.28 MB from part 14 for file.avi
29.07.2005 21:38:54: AICH successfully recovered 0 Bytes of 9.28 MB from part 13 for file.avi
29.07.2005 21:38:57: AICH successfully recovered 1.41 MB of 9.28 MB from part 20 for file.avi
29.07.2005 21:38:58: AICH successfully recovered 4.92 MB of 9.28 MB from part 22 for file.avi
29.07.2005 21:39:16: AICH successfully recovered 1.76 MB of 9.28 MB from part 23 for file.avi
29.07.2005 21:39:38: AICH successfully recovered 3.52 MB of 9.25 MB from part 24 for file.avi
29.07.2005 21:41:34: AICH successfully recovered 2.81 MB of 9.28 MB from part 15 for file.avi
29.07.2005 21:41:40: AICH successfully recovered 4.39 MB of 9.28 MB from part 18 for file.avi
29.07.2005 21:41:41: AICH successfully recovered 3.34 MB of 9.28 MB from part 21 for file.avi
29.07.2005 21:41:46: AICH successfully recovered 2.64 MB of 9.28 MB from part 19 for file.avi

The download of the file progressed on both BT and ed2k over the night

30.07.2005 4:33:30: I.C.H.: Recovered corrupted part 21 (file.avi), Saved: 19.88 KB
30.07.2005 8:17:32: I.C.H.: Recovered corrupted part 20 (file.avi), Saved: 320.00 KB
30.07.2005 8:28:18: I.C.H.: Recovered corrupted part 9 (file.avi), Saved: 12.18 KB
30.07.2005 9:35:22: I.C.H.: Recovered corrupted part 12 (file.avi), Saved: 71.59 KB
30.07.2005 12:32:19: I.C.H.: Recovered corrupted part 1 (file.avi), Saved: 262.68 KB

so I decided to import again but… mistakenly imported from the same 53% copy of the BT download.

30.07.2005 13:35:48: AICH successfully recovered 2.95 MB of 9.28 MB from part 4 for file.avi
30.07.2005 13:35:53: AICH successfully recovered 3.65 MB of 9.28 MB from part 7 for file.avi
30.07.2005 13:35:56: AICH successfully recovered 1.72 MB of 9.28 MB from part 0 for file.avi
30.07.2005 13:35:56: AICH successfully recovered 3.13 MB of 9.28 MB from part 5 for file.avi
30.07.2005 13:36:01: AICH successfully recovered 2.99 MB of 9.28 MB from part 3 for file.avi
30.07.2005 13:36:01: AICH successfully recovered 3.69 MB of 9.28 MB from part 2 for file.avi

003 now salvaged 18 more MB of the file, notably from chunks different from the first go.

First run: 09- 15-16-18-19-20-21-22-23-24
Completed overnight: 01-06-09-10-12-13-15- 18-19-20-21-22-23-24
Second run: 00-02-03-04-05-07

There are a few things that caught my eye because I cannot really explain them.

1 – Parts 01 and 12 were completed and recovered by ICH while nothing had been salvaged into part 01 and 0 bytes were salvaged into part 12. I guess that corruption in those parts occurred while they were being downloaded.
2 – In parts 9, 20 and 21 ICH reports saving significantly less than was salvaged by the import feature, whereas parts 10, 12-13, 15, 18-19, 22-24 appear to have completed with no ICH messages. Does this suggest that further corruption occurred in chunks 9, 20 and 21 during downloading?
3 – Were there indeed salvageable parts in chunks 00, 02-05 and 07 that were missed by the first run of import function, or does the situation suggest that my eMule had actually downloaded these parts over the night – they were only revealed after rehashing.
4 – Are download requests made for single 180k blocks or standard 3x180k blocks?

[roversr13]

@tHeWiZaRdOfDoS: Yes, I'm working on it. Actually I've compiled 46c version of the mod I use (it have some addtional features visual features that I have to separate before releasing standalone Import mod). I was away from development for some time, so I'm still working on GUPC request and new version that I should release soon will probably not have it. However, there'll be one more specialised tool - Bit Flip Recovery function. Thanks for delete error too - I fixed it. It was there from the time partData was allocated differently.

@slowsilver:
1: It is beause corruption was in last block of part, so ICH saved you only from finishing that block. AICH operates with 180k blocks and because of that can't recover those. Actually you could've saved most of this part - read below why it didn't happen.
2: ICH after AICH normally just save part of 180k block that left and generate only small save. It is likely that you've just downloaded new data over corruption that were really close to end of 180k block so ICH didn't even had chance to do anything.
3: Yes, it is most likely that those parts were salvageable. SR13-ImportParts only does import - all of salvage is handled by eMule's own ICH and AICH routines. As I understand, when faced with lots of parts to recover at same time (as it happens when you import data) AICH spreads requests and then stops to not overload clients too much. It is not a problem when you've downloading normally, but of course it gets in the way when you've "downloading" at speed of your HDD, where you import data from. My home version have another feature I don't release - "Request AICH Recovery" that attemtps to request AICH recovery for all parts starting from part with less completed bytes. Since I'm not sure if this feature is harmful or not (well, considering that Import is one time operation it shouldn't be harmful) I do not release it. In your situation, you may want to wait when AICH finishes its job after first import and then try to import again in a few minutes.
4: Import does not deal with download or recovery directly at all - all those task are delegated to eMule's functions that are used by eMule in it's normal operation, so you'll have to check it in AICH sources. Import itself read file in PARTSIZE sized blocks.

I guess I'll either add reimport suggestion to documentation in next version or just make "Request AICH recovery" available, unless someone tells me what problems it could cause.

This post has been edited by roversr13: 30 July 2005 - 05:45 PM

[slowsilver]

Thanks, that was excellent.

Something that confused me a bit was that file state seemed to be 'waiting' while AICH was performing its work - I wasn't sure when exactly importing was done. AICH recovery messages popped up, but I wasn't exactly sure there wouldn't be another one if I waited long enough.

I certainly would appreciate 'Request AICH Recovery' to be included or stopping AICH check, as it happens, excluded. I don't see anything harmful in 'oredered' client overload - especially since I'd think overload happens on only a limited number of systems.

[roversr13]

Wow, not only ed2k is alive - I successfully tracked recently some content I couldn't get from "official" torrent for weeks but even my mod releases that good people put up on FTP almost 15 years ago are still online too. Too bad I've only put 002 and 003 there. I'm moving source history to GitHub right now and would like to preserve all three release just for completeness sake. I'm sure I can find 001 sources somewhere on my old HDD's shelf, but before I get to it, maybe anybody here have it at hand by any chance?

It was released under this link back then:
ed2k://|file|emule-44c-SR13-ImportParts-001.src-patch.rar|2993|33CA366DBA9C9E1CB1BC5A592F1EF958|h=CJL6MRNS2XJMIJTT2UPTDN2LYDGOVB7T|/

[omeringen]

Oh, nice to see an old modder still around here.