Emule V0.50A Stullemule V7.0 It's been a while but here we go again!
#1021
Posted 13 November 2008 - 01:03 PM
[Imagine there was a sarcasm meter right here!]
No, there will not be a new version of my mods. No, I do not want your PM. No, I am certain, use the board and quit sending PMs. No, I am not kidding, there will not be a new version of my mods just because of YOU asking for it!
#1022
Posted 13 November 2008 - 01:20 PM
Stulle, on Nov 13 2008, 03:03 PM, said:
Yes I did some debugging and noticed the bug here.
bool CUpDownClient::ProcessHelloTypePacket(CSafeMemFile* data) { ..... for (uint32 i = 0; i < tagcount; i++) { CTag temptag(data, true); switch (temptag.GetNameID()) { case CT_NAME: if (temptag.IsStr()) { free(m_pszUsername); m_pszUsername = _tcsdup(temptag.GetStr());
Step throw the code and you can see clearly how "old_m_pszUsername" is freed at the same time as "m_pszUsername" you can also see that both have the same memory location.
AFAIK Xtreme mod defines old_m_pszUsername as CString for the same reason.
Also Checking if m_pszUsername isn't NULL prevents unnecessary checks in CUpDownClient::TestLeecher()
if (thePrefs.IsBadNickBan()) { //if(old_m_pszUsername != m_pszUsername) if(m_pszUsername != NULL && old_m_pszUsername != m_pszUsername) {
#1023
Posted 13 November 2008 - 02:58 PM
as for the code you mention, i think i will make the old one a cstring then or use memcpy or something like that.
[Imagine there was a sarcasm meter right here!]
No, there will not be a new version of my mods. No, I do not want your PM. No, I am certain, use the board and quit sending PMs. No, I am not kidding, there will not be a new version of my mods just because of YOU asking for it!
#1024
Posted 13 November 2008 - 08:04 PM
#1025
Posted 21 November 2008 - 04:16 AM
I can see here that if reduce score is enabled that the value of uBanReason is set to return value of the function TestLeecher() and the old value (like Suspect Hello-Tag detection) simply ignored.
bool CUpDownClient::ProcessHelloTypePacket(CSafeMemFile* data) { ..... if(thePrefs.GetEnableAntiLeecher()){ // ==> Reduce Score for leecher - Stulle /* if (strBanReason.IsEmpty()) strBanReason = TestLeecher(); if(!strBanReason.IsEmpty()) BanLeecher(strBanReason); */ if (thePrefs.IsReduceScore() || strBanReason.IsEmpty()) { uint8 uTestLeecher = TestLeecher(); if(uTestLeecher!=0) uBanReason = uTestLeecher; } if(!strBanReason.IsEmpty() || uBanReason != GOOD_BOY) BanLeecher(strBanReason,uBanReason); // <== Reduce Score for leecher - Stulle .....
I changed a line above and things like "Suspect Hello-Tag detection" work fine under reduce score. But really I can't figure out if it is by design or not?
//if (thePrefs.IsReduceScore() || strBanReason.IsEmpty()) if ((thePrefs.IsReduceScore() && uBanReason < BAN_REDUCE_COUNT) || strBanReason.IsEmpty())
PS: I might not be able to respond until later tonight since it's almost 5:50am and my eyes don't seem quite to obey my brain's signals anymore.
#1026
Posted 21 November 2008 - 10:02 AM
[Imagine there was a sarcasm meter right here!]
No, there will not be a new version of my mods. No, I do not want your PM. No, I am certain, use the board and quit sending PMs. No, I am not kidding, there will not be a new version of my mods just because of YOU asking for it!
#1027
Posted 30 November 2008 - 12:32 AM
I have a lowid friend. I activated friend slot. In messages window, i can see "establish friend slot" as ticked. But in "on queue" window in transfers tab, "establish friend slot" option seems as unticked. Is this normal ?
#1028
Posted 30 November 2008 - 08:48 AM
[Imagine there was a sarcasm meter right here!]
No, there will not be a new version of my mods. No, I do not want your PM. No, I am certain, use the board and quit sending PMs. No, I am not kidding, there will not be a new version of my mods just because of YOU asking for it!
#1029
Posted 24 December 2008 - 01:59 AM
I'm reporting the same problem that edadd01 has/had:
Stullemule 6.1 ...
Quote
I don't know if it's related but I also notice a suspiciously empty/shrinking queue. I've been using this mod for a long time and this problem is very recent.
I don't believe it was introduced by v.6.1 as I'm almost sure it worked correctly after update.
Could it be some Windows update? I'm using legit XP SP3.
#1030
Posted 24 December 2008 - 03:01 AM
This ASFU thing is happening when you rename a folder, isn't it ? Because i see same issue on my comp.
empty/shrinking queue. . . Yes that's another thing we both see. I already searched the verboseling log but there was not much info about that. It suddenly flushing the queue somethimes.
This post has been edited by erdem444: 24 December 2008 - 03:02 AM
#1031
Posted 24 December 2008 - 01:42 PM
I'm not sure but this is what I think triggered it somehow:
My eMule setup has been the same in a long time. Temporary Files dir is on separate partition on a separate disc drive. Incoming Files and Shared dirs are also on that disc drive on a data partition. Shared dirs vary sometimes by check/unchecking them but are never renamed. DLed files are always renamed. I do it through eMule's Details/Rename/Mass Rename context menu to avoid possible hashing problems.
Recently though I had a major data disc failure. With that disc gone I had to change the Temporary, Incoming and Shared dirs to the system disc and I noticed the problem since. I thought ASFU might still be checking for the missing disc but clearing the Inactive Shares did not solve it.
#1032
Posted 24 December 2008 - 02:38 PM
[Imagine there was a sarcasm meter right here!]
No, there will not be a new version of my mods. No, I do not want your PM. No, I am certain, use the board and quit sending PMs. No, I am not kidding, there will not be a new version of my mods just because of YOU asking for it!
#1033
Posted 02 March 2009 - 11:11 PM
I have just got a report from a user. Want to notify about it;
After an unexpected shutdown(electricity offline, power cut. . .), shared directories(not temp or incoming folders) are disappearing. StulleMule is starting to rehash the files after resharing these disappeared files.(that means there is a problem about known*.met files as far as i understand)
#1034
Posted 02 March 2009 - 11:26 PM
Lovelace Credit System is the best way to reward the good uploaders
#1035
Posted 02 March 2009 - 11:30 PM
[Imagine there was a sarcasm meter right here!]
No, there will not be a new version of my mods. No, I do not want your PM. No, I am certain, use the board and quit sending PMs. No, I am not kidding, there will not be a new version of my mods just because of YOU asking for it!
#1036
Posted 04 March 2009 - 05:36 AM
afaik theres been nothing wrong with my net connection at these times also
#1037
Posted 04 March 2009 - 08:49 AM
[Imagine there was a sarcasm meter right here!]
No, there will not be a new version of my mods. No, I do not want your PM. No, I am certain, use the board and quit sending PMs. No, I am not kidding, there will not be a new version of my mods just because of YOU asking for it!
#1038
Posted 04 March 2009 - 09:26 AM
This post has been edited by NksTV: 04 March 2009 - 09:32 AM
#1039
Posted 04 March 2009 - 09:39 AM
NksTV, on Mar 4 2009, 10:26 AM, said:
No. Especially not if you only log "Log upload/download events" (see Options/Extended), which I assume is the relevant part.
I've seen something similar when using latest morph. The upload speed is suddenly starting to crawl and no new slots are opened. I've some screenshots of Stats and verbose logs about it at home. I'll post them when I return from work later.
Afaik everytime it happened I've found a xunlei client (like xl buildxx, zzul plus, don't remeber exactly) in the upload queue. I have no idea why though.
This post has been edited by Nissenice: 04 March 2009 - 09:43 AM
#1040
Posted 04 March 2009 - 01:16 PM
[Imagine there was a sarcasm meter right here!]
No, there will not be a new version of my mods. No, I do not want your PM. No, I am certain, use the board and quit sending PMs. No, I am not kidding, there will not be a new version of my mods just because of YOU asking for it!