[Tuxman]

Hm, thank you then.

[CiccioBastardo]

Thanks jerryBG!

Hey Tux, did you sub-contract the work?

@LorenzoC
It possibly is a problem with the new added columns. Probably the old sorting criteria is not restored at client startup, so the reload does nothing because the sorting rule is not set until you press the column title again.
Going to fix all this for the next release.

[Tuxman]

CiccioBastardo, on 14 November 2009 - 08:50 , said:

Hey Tux, did you sub-contract the work?

I think I will fork it to a derivative work, just to be sure.
(Works in beba, with a few small modifications...)

[jerryBG]

 hi there, i have stumbled upon this, tho' merely non-critical

ClientDetailDialog.cpp

        // <CB Mod : Optimization : Date 11.07.07>
#ifdef CB_MOD_EXTRAINFO_ENABLED
        GetDlgItem(IDC_DSOFT)->SetWindowText(client->GetClientSoftVer());
        if (client->GetClientModVer().IsEmpty())
            GetDlgItem(IDC_DSOFT)->SetWindowText(client->GetClientSoftVer());
        else {
#ifdef CB_MOD_ILLEGALMODSFILTER_ENABLED
            buffer.Format(_T("%s [%s] %s"), client->GetClientSoftVer(), client->GetClientModVer(), client->IsGPLViolator()?_T("<<GPL violator!>>"):client->IsIllegalMod()?_T("<<Illegal Mod>>"):_T(""));
#else
            buffer.Format(_T("%s [%s]"), client->GetClientSoftVer(), client->GetClientModVer());
#endif
            GetDlgItem(IDC_DSOFT)->SetWindowText(buffer);
        }
#endif
        // </CB Mod : Optimization>

i believe should be this way

        // <CB Mod : Optimization : Date 11.07.07>
#ifndef CB_MOD_EXTRAINFO_ENABLED //jerry: changed #ifdef -> #ifndef
        GetDlgItem(IDC_DSOFT)->SetWindowText(client->GetClientSoftVer());
#else //jerry: added #else
        if (client->GetClientModVer().IsEmpty())
            GetDlgItem(IDC_DSOFT)->SetWindowText(client->GetClientSoftVer());
        else {
#ifdef CB_MOD_ILLEGALMODSFILTER_ENABLED
            buffer.Format(_T("%s [%s] %s"), client->GetClientSoftVer(), client->GetClientModVer(), client->IsGPLViolator()?_T("<<GPL violator!>>"):client->IsIllegalMod()?_T("<<Illegal Mod>>"):_T(""));
#else
            buffer.Format(_T("%s [%s]"), client->GetClientSoftVer(), client->GetClientModVer());
#endif
            GetDlgItem(IDC_DSOFT)->SetWindowText(buffer);
        }
#endif
        // </CB Mod : Optimization>

 




jerryBG   

(work status: freelance)

[CiccioBastardo]

Yep, thanks

[pier4r]

I make a feature request: multiqueue option (not hardcoded) for this great mod for better distribution of accepted request between files (imo).

Else, np, it's already good.

[Eulero]

maybe still problems with sorting, but I have not verified if there is also with ZZUL..
in the window "in coda", with files in powershare, many columns don't work, .e.g. "punteggio coda" , "accodato da" , "numero IP ", "dimensione" .......

[coluche]

hej,

The BastarD still runs smoothly all the time, over here.

So, is Zz still around ? So there would be a chance of a new Zzul Mod ?

[MadlyMad]

coluche, on 01 May 2010 - 02:02 AM, said:

So, is Zz still around ? So there would be a chance of a new Zzul Mod ?

Really hope so, for both questions

[CiccioBastardo]

coluche, on 01 May 2010 - 02:02 AM, said:

hej,

The BastarD still runs smoothly all the time, over here.

So, is Zz still around ? So there would be a chance of a new Zzul Mod ?

Hi,
I have to close it manually after a couple of months of continuous working in order to fix the statistics calculations which go berserk after a certain time.

Unfortunately, even though ZZ will update his mod to the new code, I do not know if I will ever update mine (if that is of interest to anyone).
I have too few spare time lately and that mostly goes to sleep. Sometimes I can sleep even 6 complete hours at night! But only when I am lucky.

See you.

[Tuxman]

Real life is more important than the mule indeed.

Although we all look forward to you having more spare time again ...

[coluche]

huh, I thought to have answered a while ago already.

By all means, try to have a perspective that that situation changes.
I think one can live like that for a while, but after some years it starts wearing you off seriously.

And of course an updated version of the BastarD would be nice and apreciated, but it is not as if we drop dead without it.
Official is also fine.

Good luck.

[Eulero]

I noticed only now that Bastard remove the client after 3 months.

UINT count = file.ReadUInt32();
		m_mapClients.InitHashTable(count+5000); // TODO: should be prime number... and 20% larger

		
		// <CB Mod : Credit Expiration : Date 27.01.08>
#ifdef CB_MOD_SUQWT_ENABLED
		uint32 expireTime = 12960000; // today - 150 day
		if (count > 20000)
			expireTime = 7776000; // today - 90 day

		const uint32 dwExpired = time(NULL) - expireTime;
#else
		const uint32 dwExpired = time(NULL) - 12960000; // today - 150 day
#endif
		// </CB Mod : Credit Expiration : Date 27.01.08>

What does this mean? Why? Perhaps, if the file is "too big" (more than 20000 clients saved) remove after 3 months instead of 5?

[Stulle]

well, the code does indicate this. you should, however, know that the official purges those entries after 90 days, no matter what. so it's longer for Bastard mod if it's not too much clients.