Official eMule-Board: A Fix To Mulelistctrl.cpp - Official eMule-Board

Jump to content


Page 1 of 1

A Fix To Mulelistctrl.cpp a double fixer LoL

#1 User is offline   Avi-3k 

  • hebMule [retired] dev
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 1,125
  • Joined: 25-June 03

Posted 10 August 2004 - 09:00 PM

hi all

there's a problem with the selection in MuleListCtrl.cpp,
sometimes the code won't know u used it...
that made the Del key not to remove
files from DL list (the second fix by the patch :lol:)

the original code

MuleListCtrl.cpp said:

...
void CMuleListCtrl::onkeydown(UINT nChar,UINT nRepCnt,UINT nFlags){
if ( nChar=='A' && ::GetAsyncKeyState(VK_CONTROL)<0) {
    LV_ITEM theItem;
    theItem.mask= LVIF_STATE;
    theItem.iItem= -1;
    theItem.iSubItem= 0;
    theItem.state= LVIS_SELECTED;
    theItem.stateMask= 2;
    SetItemState(-1, &theItem);

  }
...
}
...


the new code

MuleListCtrl.cpp said:

...
void CMuleListCtrl::onkeydown(UINT nChar,UINT nRepCnt,UINT nFlags){
if ( nChar=='A' && ::GetAsyncKeyState(VK_CONTROL)<0) {
    // Ctrl+A: Select all items
    // Avi3k: selection fix
    UINT flag = LVIS_SELECTED | LVIS_FOCUSED;
    for (int i=0; i<GetItemCount(); i++)
        SetItemState(i, flag, flag);
    // end Avi3k: selection fix

  }
...
}
...


that fix will take care of both the selection
and the del key in DL list :+1:

Avi3k
retired developer of hebMule and eMule Skinner...
hebMule site and topic.
hebMule2 unique features: AntiLeech, AntiVirus, Fake Check, ServerFilter, WebSearches, Export Searches, Relative Priority, ModID and much much more...

eMule Skinner is an application to create/edit skins for eMule,
it's multilingual, supports mods, easy-to-use design, integrates to hebMule & Windows and lots more...

code fixes/improvements: #1, #2, #3, #4, #5, #6, #7, #8, #9, #10, #11 (to check/verify: #12, #13).
0

#2 User is offline   stormit 

  • Stormit-Mod-Dev.
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 2,605
  • Joined: 26-December 02

Post icon  Posted 11 August 2004 - 10:39 PM

Hi Avi-3k :D

How are my friend, thanks I will put you patch in my next release. Cheers :thumbup:

This post has been edited by stormit: 11 August 2004 - 10:39 PM

Kind Regards, Stormit user posted image
Remember Sharing is Caring, Please Share All that you can. Thank You!
Remember that I'm only human and make mistakes, dont we all!
Stormit's Mod's Area, Try Them Out - Khaotic Statistics and alot more!
Stormit's Mod's Website, other files, links and more!
New eMule Content Database, help support freeware!
I Like the Moon it's Rather-Good, very funny song!!!
0

#3 User is offline   .: Elite :. 

  • Advanced Member
  • PipPipPip
  • Group: Members
  • Posts: 67
  • Joined: 30-January 04

Posted 12 August 2004 - 04:23 AM

Hi Avi,

thanks for the Patch ... :thumbup:

allready implemented!

Rgds

.: Elite :.
0

#4 User is offline   Avi-3k 

  • hebMule [retired] dev
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 1,125
  • Joined: 25-June 03

Posted 12 August 2004 - 06:43 AM

hi Stormit & Elite
u'r welcome :thumbup:

i wasn't sure ppl noticed this patch :lol:

Regards,
Avi3k
retired developer of hebMule and eMule Skinner...
hebMule site and topic.
hebMule2 unique features: AntiLeech, AntiVirus, Fake Check, ServerFilter, WebSearches, Export Searches, Relative Priority, ModID and much much more...

eMule Skinner is an application to create/edit skins for eMule,
it's multilingual, supports mods, easy-to-use design, integrates to hebMule & Windows and lots more...

code fixes/improvements: #1, #2, #3, #4, #5, #6, #7, #8, #9, #10, #11 (to check/verify: #12, #13).
0

#5 User is offline   ziteribo 

  • Advanced Member
  • PipPipPip
  • Group: Members
  • Posts: 64
  • Joined: 23-July 04

Post icon  Posted 22 July 2005 - 02:01 PM

Avi-3k, on Aug 12 2004, 06:43 AM, said:

hi Stormit & Elite
u'r welcome :thumbup:

i wasn't sure ppl noticed this patch  :lol:

Regards,
Avi3k
View Post


Not corrected in 0.46b code ...
0

#6 User is offline   eMulefan83 

  • eF-Mod - Dev
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 1,467
  • Joined: 22-April 03

Posted 26 July 2005 - 08:32 PM

ziteribo, on Jul 22 2005, 02:01 PM, said:

Avi-3k, on Aug 12 2004, 06:43 AM, said:

hi Stormit & Elite
u'r welcome :thumbup:

i wasn't sure ppl noticed this patch  :lol:

Regards,
Avi3k
View Post


Not corrected in 0.46b code ...
View Post


Oh really,
itīs still the same code. No fix in official till now. :(
0

#7 User is offline   Tuxman 

  • lizzie and prog-rock fanatic
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 2,602
  • Joined: 26-July 04

Posted 26 July 2005 - 09:15 PM

Not even fixed in .46c :)
[ eMule beba ] :: v2.72 released, v3.00 in the works ...
- feel the lightweight! - featuring Snarl support, the Client Analyzer and tits!
Coded by a Golden eMule Award winner and most people's favorite modder!
..........................................
Music, not muzak:
Progressive Rock :: my last.fm profile
..........................................
eMule user since 0.28 ...
-[ ... and thanks for all the fish! ]-
0

#8 User is offline   eMulefan83 

  • eF-Mod - Dev
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 1,467
  • Joined: 22-April 03

Posted 26 July 2005 - 09:57 PM

Tuxman, on Jul 26 2005, 09:15 PM, said:

Not even fixed in .46c :)
View Post

Like i wrote:

Til now :-k
0

#9 User is offline   PacoBell 

  • Professional Lurker Ž_Ž (so kyoot!)
  • PipPipPipPipPipPipPip
  • Group: Moderator
  • Posts: 7,295
  • Joined: 04-February 03

Posted 26 July 2005 - 10:02 PM

eMulefan83, on Jul 26 2005, 01:57 PM, said:

Like i wrote:

Til now  :-k
View Post
I think you have your english in a muddle. "til" is an abbreviation of "until" which implies that said event has already occured since it's used in conjuction with the word "now", indicating finality. HTH.
Sed quis custodiet ipsos custodes
Math is delicious!
MmMm! Mauna Loa Milk Chocolate Toffee Macadamias are little drops of Heaven ^_^
Si vis pacem, para bellum DIE SPAMMERS DIE!

#10 User is offline   Tuxman 

  • lizzie and prog-rock fanatic
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 2,602
  • Joined: 26-July 04

Posted 26 July 2005 - 10:02 PM

Thought you referred to "0.46b". :P

@PacoBell: lol

This post has been edited by Tuxman: 26 July 2005 - 10:02 PM

[ eMule beba ] :: v2.72 released, v3.00 in the works ...
- feel the lightweight! - featuring Snarl support, the Client Analyzer and tits!
Coded by a Golden eMule Award winner and most people's favorite modder!
..........................................
Music, not muzak:
Progressive Rock :: my last.fm profile
..........................................
eMule user since 0.28 ...
-[ ... and thanks for all the fish! ]-
0

#11 User is offline   eMulefan83 

  • eF-Mod - Dev
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 1,467
  • Joined: 22-April 03

Posted 26 July 2005 - 10:05 PM

PacoBell, on Jul 26 2005, 10:02 PM, said:

eMulefan83, on Jul 26 2005, 01:57 PM, said:

Like i wrote:

Til now  :-k
View Post
I think you have your english in a muddle. "til" is an abbreviation of "until" which implies that said event has already occured since it's used in conjuction with the word "now", indicating finality. HTH.
View Post

Sorry,

and thanks for the lesson.
I know my english isnīt the best. :cry:
0

#12 User is offline   Avi-3k 

  • hebMule [retired] dev
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 1,125
  • Joined: 25-June 03

Posted 27 July 2005 - 07:40 AM

i don't think it's that bad
it seems i can't reproduce this bug
(maybe since this fix is a year old,
maybe cuz no fix is needed anymore)

Avi3k
retired developer of hebMule and eMule Skinner...
hebMule site and topic.
hebMule2 unique features: AntiLeech, AntiVirus, Fake Check, ServerFilter, WebSearches, Export Searches, Relative Priority, ModID and much much more...

eMule Skinner is an application to create/edit skins for eMule,
it's multilingual, supports mods, easy-to-use design, integrates to hebMule & Windows and lots more...

code fixes/improvements: #1, #2, #3, #4, #5, #6, #7, #8, #9, #10, #11 (to check/verify: #12, #13).
0

  • Member Options

Page 1 of 1

1 User(s) are reading this topic
0 members, 1 guests, 0 anonymous users