Official eMule-Board: Missing Check In Process_Kademlia2_Res ? - Official eMule-Board

Jump to content


Page 1 of 1

Missing Check In Process_Kademlia2_Res ?

#1 User is offline   Nissenice 

  • clippetty-clopping...
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 4,231
  • Joined: 05-January 06

Posted 04 October 2011 - 08:35 PM

Hi

When a KADEMLIA2_REQ has been sent and the response is coming back from the responding node there is a check in CSearch::ProcessResponse() whether the asked node is sending more contacts than asked for.
But - unless I've missed something - there is no check in Process_KADEMLIA2_RES() to prevent attempts by the responding node to add more contacts to the asking node's routing table than expected. I've a feeling this could be exploited, especially if the asking node's client just has started and the routing table is building up.

This post has been edited by Nissenice: 04 October 2011 - 08:46 PM

0

#2 User is offline   Some Support 

  • Last eMule
  • PipPipPipPipPipPipPip
  • Group: Yes
  • Posts: 3,534
  • Joined: 27-June 03

Posted 05 October 2011 - 10:45 AM

True, this check could and should be done there too. Not a big security issue, but worth implementing it.

#3 User is offline   Nissenice 

  • clippetty-clopping...
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 4,231
  • Joined: 05-January 06

Posted 07 October 2011 - 12:20 AM

Ok, thanks! I can't say that I've seen this happen. Not that I look at the verbose all the time, but though...

And another thing... :P ... After that check in CSearch::ProcessResponse() the call is aborted, but shouldn't the list of contacts (plistResults) be deleted before the return statement, like it is in CSearchManager::ProcessResponse when the search has been deleted?

		for (ContactList::const_iterator itContactList = plistResults->begin(); itContactList != plistResults->end(); ++itContactList)
			delete (*itContactList);
		delete plistResults;
		return;

This post has been edited by Nissenice: 07 October 2011 - 12:22 AM

0

  • Member Options

Page 1 of 1

1 User(s) are reading this topic
0 members, 1 guests, 0 anonymous users