[James R. Bath]

Please provide a level setting that disables IdentifierDesc logging while keeping the rest of the verbose logging.

To me, the present read/write IdentifierDesc logging is more like a bug. There's no context for what, if anything, it means, and it adds 15% more size/processing to the verbose logs. On the off chance that it is a badly implemented "enhancement" that somebody actually dedicated time to add, I'd like a further enhancement.

Presently, the only way to get rid of the IdentifierDesc logging is to set the level to 2, which happens to stop all verbose logging, making level 1 pointless. Levels 3-5 show no significant difference. How about level 5 shows IdentifierDesc lines and all levels below it do not?

[Famerlor]

I second that, showing the identifierdesc-lines only at level 5 should be sufficient, so that levels 1-4 are NOT showing these lines.

[James R. Bath]

Here's the fix to the 50a source and any mods that also use it without first removing the incomplete code with essential //TODO left:

srchybrid\FileIdentifier.cpp

    DebugLog(DLP_VERYHIGH, _T("Write IdentifierDesc: %u"), byIdentifierDesc);
    pFile->WriteUInt8(byIdentifierDesc);
    uint8 byIdentifierDesc = pFile->ReadUInt8();
    DebugLog(DLP_VERYHIGH, _T("Read IdentifierDesc: %u"), byIdentifierDesc);
    bool bMD4	= ((byIdentifierDesc >>  0) & 0x01) > 0;
    bool bSize	= ((byIdentifierDesc >>  1) & 0x01) > 0;
    bool bAICH	= ((byIdentifierDesc >>  2) & 0x01) > 0;
    uint8 byMOpt= ((byIdentifierDesc >>  3) & 0x03);
    uint8 byOpts= ((byIdentifierDesc >>  5) & 0x07);

For reference, no changes necessary:
Log.h

enum EDebugLogPriority{
	DLP_VERYLOW = 0,
	DLP_LOW,
	DLP_DEFAULT,
	DLP_HIGH,
	DLP_VERYHIGH
};};

Expert code readers may also want to look at whether thePrefs.GetVerboseLogPriority is a redundant function that can be deleted and its 2 dependencies corrected. For example:

PartFile.cpp:

				if (dwError != ERROR_INVALID_FUNCTION && thePrefs.GetVerboseLogPriority() <= DLP_VERYLOW)
					DebugLogError(_T("Failed to apply NTFS sparse file attribute to file \"%s\" - %s"), partfull, GetErrorMessage(dwError, 1));

changed to:

				if (dwError != ERROR_INVALID_FUNCTION)
					DebugLogError(DLP_VERYLOW, _T("Failed to apply NTFS sparse file attribute to file \"%s\" - %s"), partfull, GetErrorMessage(dwError, 1));

This post has been edited by James R. Bath: 14 July 2010 - 10:52 PM

[Tuxman]

James R. Bath, on 14 Juli 2010 - 11:48 , said:

  uint8 byIdentifierDesc = (uint8)
    DebugLog(DLP_VERYHIGH, _T("Write IdentifierDesc: %u"), byIdentifierDesc);

Something missing there, eh?

[James R. Bath]

Not so much missing as forgot to delete the uint8 byIdentifierDesc = (uint8) line. From that to the DebugLog doesn't need any change. Thank you and corrected.

This post has been edited by James R. Bath: 14 July 2010 - 10:53 PM

[aaa3i]

this still need to be fixed please