[Avi-3k]

i got a chance to try out the new Visual Studio 2010,
so one of the things i've tested is compiling the latest eMule

first of all, eMule 0.50a does compile though it requires some changes:
1. the class CMemDC should be renamed to be compatible with VS2010
(MS added a class named CMemDC in latest MFC)

2. _MSC_VER is set to 1600, _MFC_VER is set to 0x0A00 so
emule_site_config.h and __AfxSocketTerm() should reference them respectively
(btw, some files like qedit.h iirc are not included, but VS2010 uses latest SDK)

3. for some reason, the included libs (id3lib, CxImage & miniupnplib) require to be compiled
with MFC staticly linked (at least this is how it worked for me... not sure why )
also, crypto++ (v5.6) requires replacing one NULL to nullptr

4. in emule's project properties you need to add MSVCRT.lib to linker > input > ignore specific library
(at least this is how it worked for me...)

this is based on converting the vc8 project files to VS2010 (since i use VS2005 in my usual dev. env.)
if the devs are interested, i can cleanup some stuff and send you the project files as there are changes to the format


btw, a quick review on VS2010 for those who want to know (my opinion, at least):
bloatware cannot desctibe it, so much stuff was added to my add/remove program, god knows why... most of them are required for VS to properly work.
there are some useful changes to C++ (didn't get to see/check them all) but still no Refactoring like in C#.
the most annoying thing of all was the tray popup each time i opened VS that asked me to help improve VS (as if once is not enough)

Regards,
Avi3k

This post has been edited by Avi-3k: 07 May 2010 - 09:05 PM

[xilolee]

Avi-3k, on 20 April 2010 - 11:42 PM, said:

4. in emule's project properties you need to add MSVCRT.lib to linker > input > ignore specific library
(at least this is how it worked for me...)

I had to do it also with vs2003, without vista/seven sdks

[Avi-3k]

yeah, i know, your post helped me remember what i read on msdn,
thank you

Avi3k

[Some Support]

I just can't help but wonder why MS made VS2010 look that ugly. I mean every VS had a new GUI and most of them looked a bit more modern even if it take time to get used too, but that strange blue in VS2010 makes me feel like a timejump back to the days of Win95 and OS/2.

[Avi-3k]

Some Support, on 24 April 2010 - 12:02 AM, said:

I just can't help but wonder why MS made VS2010 look that ugly. I mean every VS had a new GUI and most of them looked a bit more modern even if it take time to get used too, but that strange blue in VS2010 makes me feel like a timejump back to the days of Win95 and OS/2.

thanks for pointing out the uglyness, i forgot about that one... (thank god )

did you compile eMule with VS2010 already?

Avi3k

[xilolee]

Avi-3k, if you know also how to eliminate those warnings (without hiding them obviously), it would be interesting (at least for me that i'm a newbie)

[Some Support]

Avi-3k, on 23 April 2010 - 10:20 PM, said:

did you compile eMule with VS2010 already?

No, don't really intend to neither atm.

[Avi-3k]

xilolee, on 24 April 2010 - 12:26 AM, said:

Avi-3k, if you know also how to eliminate those warnings (without hiding them obviously), it would be interesting (at least for me that i'm a newbie)

warnings aren't an issue, though to eliminate them, the best way is to search
the error/warning/link code (e.g: LNK2005, C2010 etc) in msdn and follow the explanations...

Avi3k

[xilolee]

In fact, IIRC, the help says: code is exported and then is re-imported (said with words of mine!).
Maybe does it add value (tax on the added value - IVA in italy ) to the release?

Quote

LNK4049: exported symbol "symbol" also imported - The symbol was both exported from and imported to the program.

LNK4217: locally defined symbol 'symbol' imported in function 'function' - __declspec(dllimport) was specified for a symbol even though the symbol is defined locally. Remove the __declspec modifier to resolve this warning.

symbol is the symbol name that's defined within the image. function is the function that is importing the symbol.

I searched __declspec, but I think it is too much deep in the code for me!

This post has been edited by xilolee: 25 April 2010 - 09:15 PM

[netfinity]

Avi-3k, on 20 April 2010 - 11:42 PM, said:

3. for some reason, the included libs (id3lib, CxImage & miniupnplib) require to be compiled
with MFC staticly linked (at least this is how it worked for me... not sure why )

I also had to replace a NULL macro with a nullptr object in cryptolib to make it compile. Has with a new standard feature in the STL libraries to do.

Avi-3k, on 20 April 2010 - 11:42 PM, said:

bloatware cannot desctibe it, so much stuff was added to my add/remove program, god knows why... most of them are required for VS to properly work.

Next to Windows I'm also using Linux, so I'm used to have millions of programs/modules cluttering the system just to run one simple app.

Avi-3k, on 20 April 2010 - 11:42 PM, said:

there are some useful changes to C++ (didn't get to see/check them all) but still no Refactoring like in C#.

Most useful changes I think is when you are using template libraries alot. A lot of candy there, althought I still miss some features from the proposed CPP0X standard that would allow to make some very powerful meta coding. However microsoft claims that the compiler should have been upgraded to generate alot more efficient code than previous releases. Especially in 64bit builds they claimed that you could get as much as upto 30% improvement in some situations.

Avi-3k, on 20 April 2010 - 11:42 PM, said:

the most annoying thing of all was the tray popup each time i opened VS that asked me to help improve VS (as if once is not enough)

Hmm, don't get that on my Ultimate RTM version. But I think I had it on the beta, when thinking about it.

Some Support, on 23 April 2010 - 11:02 PM, said:

I just can't help but wonder why MS made VS2010 look that ugly. I mean every VS had a new GUI and most of them looked a bit more modern even if it take time to get used too, but that strange blue in VS2010 makes me feel like a timejump back to the days of Win95 and OS/2.

I think they did it to increase the effective workspace, but I concur it looks a bit antiquated.

xilolee, on 23 April 2010 - 11:26 PM, said:

Avi-3k, if you know also how to eliminate those warnings (without hiding them obviously), it would be interesting (at least for me that i'm a newbie)

Do, you mean the typecast warnings? I'm quite sure you got them with VS2008 also, atleast did I! You either just ignore them or you either fix the code to use consequent types (which would require getting rid of MFC as a starter) or add the proper static_cast<> operators where appropriate. However if you don't intend to do any modding to a specific piece of code then you're better of just ignoring the warnings unless you know exactly what you are doing. Putting a cast operator at the wrong place can easily crash emule, even if it gets rid of the warning. The thing is that putting a cast operator into C++ code is threated by the compiler as "I know what I'm doing, even if it looks/is stupid".

[Avi-3k]

netfinity, on 26 April 2010 - 12:16 AM, said:

Avi-3k, on 20 April 2010 - 11:42 PM, said:

3. for some reason, the included libs (id3lib, CxImage & miniupnplib) require to be compiledwith MFC staticly linked (at least this is how it worked for me... not sure why )

I also had to replace a NULL macro with a nullptr object in cryptolib to make it compile. Has with a new standard feature in the STL libraries to do.

forgot about that one... thanks netfinity


also, after checking some more stuff, i noticed the project settings aren't handled correctly,
i've set the output filename (for libs) and in some cases VS2010 just ignores it

Avi3k

[bengarchy]

Thanks for the post, wish I'd found it before trying compiling with VS2010 myself! Just one small thing to add:

Avi-3k, on 21 April 2010 - 05:42 AM, said:

2. _MSC_VER is set to 1600, _MFC_VER is set to 0x1000 so
emule_site_config.h and __AfxSocketTerm() should reference them respectively
(btw, some files like qedit.h iirc are not included, but VS2010 uses latest SDK)

_MFC_VER is set to 0x0A00, not 0x1000.

As stated in MSDN Library, right at the bottom of the page:

Quote

_MFC_VER = 0x0A00 in VS 2010

It's incorrectly stated that in VS 2010 _MFC_VER is defined as 0x1000. Upon inspection of afxver.h file _MFC_VER is 0x0A00 as one would expect


#ifndef _MFC_VER
#define _MFC_VER 0x0A00 // Microsoft Foundation Classes version 10.00
#endif

Hope that helps! [=

[Avi-3k]

thanks bengarchy, though it would've been nice
if MS didn't have that error in the first place
updated first post

Avi3k

[DavidXanatos]

The new documentation of VS 2010 is strange,
is there a way to get an index like in the good old msdn where you just type the name of the function you dont remember the parameters to or class and get directly to what you ware looking for?

[Avi-3k]

not sure, i didn't install the msdn, only VS (waste of space, imo)
you could google the function with site:msdn.microsoft.com in the search string, that's whay i usually do

Avi3k

[DavidXanatos]

Well... mmh... yea it takes space... cause well it works offline.
And for me thats kinda the point MS could bankrupt tomorrow and I still have all informations I need.

When the world ends and I'm sitting in my bunker while the ww is down for good, i still can user VS and programm, and well than I'll have endless time to use up

I'm just a fan of maximal independence,
and all this cloud/live Cr4p that is flooding the cyberspace is some how of a threat to liberty, you get Dependant on the providers.

They can squise your bals as thay when they want ans when they wan, thats somehow very unpleasant.

I mean sure some stuff cant be offline and thats ok, but this that can be should be.

This post has been edited by DavidXanatos: 17 May 2010 - 09:39 PM

[Avi-3k]

if you have the space and it's possible, install an older version and the current version of the msdn,
that would solve your problem in a way...

DavidXanatos, on 18 May 2010 - 12:37 AM, said:

When the world ends and I'm sitting in my bunker while the ww is down for good, i still can user VS and programm...

in Israel we never worry about that

Avi3k

[arden]

Hey Avi3k,

Any chance of an ed2k link to a precompiled emule package with libs for 2010?

Save us some time in editing/compiling etc..

Cheers,
arden

[Stulle]

yeah... get it here!

honestly, nobody will bother compiling the whole thing with VS10, compress and upload some 500 to 800 MB worth of files!

[Avi-3k]

@arden
like Stulle said, it would be easier for all if you did the steps above yourself

Avi3k

This post has been edited by Avi-3k: 29 May 2010 - 09:01 PM