Official eMule-Board: Wrong Folder Usage In Muliuser Environments - Official eMule-Board

Jump to content

Page 1 of 1
  • You cannot start a new topic
  • You cannot reply to this topic

Wrong Folder Usage In Muliuser Environments

#1 User is offline   tHeWiZaRdOfDoS 

  • He's MaGiC
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 4680
  • Joined: 28-December 02

Posted 31 October 2009 - 07:41 AM

Well, I just noticed (due to a bug report by a tester of mine) that the EMULE_CONFIGBASEDIR is still used in several places where we need write permissions and thus the code will fail in multi-user environments - that's namely:
  • the onlinesig.dat file
  • the perflog.csv/perflog.mrtg files
  • the status.log file

Shouldn't those point to EMULE_CONFIGDIR?

Also, SecRunAsUser will fail in that cases because

Quote

bSucceeded = bSucceeded && SetObjectPermission(thePrefs.GetMuleDirectory(EMULE_CONFIGBASEDIR), FULLACCESS);

will fail - maybe this should be dropped (not needed if the above mentioned changes are applied)?

Best regards,
WiZ

Start into eMuleFuture now! Successor to my TS - includes all of its features and much more!

* New age leecher detection via ClientAnalyzer heuristics! Never needs an update and punishes only clients which really behave badly.
* Powersharing, automatic and global hardlimit, real full chunk transfers, DBR system, IntelliFlush and much more... increase the efficiency of both uploaders and downloaders
* improved GUI and display options, e.g. let eMuleFuture show a flag in front of your files to display where most of the sources of that file come from...

There is so much more! Start now!



This post has been edited 937 times, the last time by tHeWiZaRdOfDoS: Today, 12:27 PM
0

#2 User is offline   Some Support 

  • Last eMule
  • PipPipPipPipPipPipPip
  • Group: Yes
  • Posts: 2943
  • Joined: 27-June 03

Posted 31 October 2009 - 08:30 AM

View PosttHeWiZaRdOfDoS, on 31 October 2009 - 07:41 AM, said:

Well, I just noticed (due to a bug report by a tester of mine) that the EMULE_CONFIGBASEDIR is still used in several places where we need write permissions and thus the code will fail in multi-user environments - that's namely:
  • the onlinesig.dat file
  • the perflog.csv/perflog.mrtg files
  • the status.log file

Shouldn't those point to EMULE_CONFIGDIR?

No and EMULE_CONFIGBASEDIR should always have write permission, on a multiuser env this would be for example "C:\Users\Username \AppData\Local\eMule\", which is a folder which eMule created. And we want certrain files there, instead into the config directory (+ "\config") as they actually aren't really config files.

Quote

Also, SecRunAsUser will fail in that cases because

Quote

bSucceeded = bSucceeded && SetObjectPermission(thePrefs.GetMuleDirectory(EMULE_CONFIGBASEDIR), FULLACCESS);

will fail - maybe this should be dropped (not needed if the above mentioned changes are applied)?


No, as written we always need full access to this folder - and this function is only executed if we are in "store in programm directory" mode.

#3 User is offline   tHeWiZaRdOfDoS 

  • He's MaGiC
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 4680
  • Joined: 28-December 02

Posted 31 October 2009 - 11:11 AM

Hm, well, I'll have my tester post some logs later on, maybe those are helpful.

Start into eMuleFuture now! Successor to my TS - includes all of its features and much more!

* New age leecher detection via ClientAnalyzer heuristics! Never needs an update and punishes only clients which really behave badly.
* Powersharing, automatic and global hardlimit, real full chunk transfers, DBR system, IntelliFlush and much more... increase the efficiency of both uploaders and downloaders
* improved GUI and display options, e.g. let eMuleFuture show a flag in front of your files to display where most of the sources of that file come from...

There is so much more! Start now!



This post has been edited 937 times, the last time by tHeWiZaRdOfDoS: Today, 12:27 PM
0

#4 User is offline   tHeWiZaRdOfDoS 

  • He's MaGiC
  • PipPipPipPipPipPipPip
  • Group: Members
  • Posts: 4680
  • Joined: 28-December 02

Posted 01 November 2009 - 06:54 AM

I'm sorry, I was looking into the wrong direction. The user set up a new directory and Windows had no rights to write to it.

Start into eMuleFuture now! Successor to my TS - includes all of its features and much more!

* New age leecher detection via ClientAnalyzer heuristics! Never needs an update and punishes only clients which really behave badly.
* Powersharing, automatic and global hardlimit, real full chunk transfers, DBR system, IntelliFlush and much more... increase the efficiency of both uploaders and downloaders
* improved GUI and display options, e.g. let eMuleFuture show a flag in front of your files to display where most of the sources of that file come from...

There is so much more! Start now!



This post has been edited 937 times, the last time by tHeWiZaRdOfDoS: Today, 12:27 PM
0
Page 1 of 1
  • You cannot start a new topic
  • You cannot reply to this topic

1 User(s) are reading this topic
0 members, 1 guests, 0 anonymous users