[Rapid_Mule]

Well I hope i get this one right and avoid the wrath of our well "composed" Stulle.
I get GDI leaks after closing Prefrences-Directories the counters just keep going up is it a leak?

PS: just finished monitoring the official 0.48a client and I get the same leaks (It's not me that's leaking, so don't get any fancy ideas you weirdos).

[Enig123]

That would better to report also in the Bug-Report section of this forum so the official team can notice it more easily.

[Rapid_Mule]

Enig123, on Dec 17 2007, 04:18 AM, said:

That would better to report also in the Bug-Report section of this forum so the official team can notice it more easily.

If someone else confirms the issue then Leuk_he can move the topic there.

Regards.

[Enig123]

Rapid_Mule, on Dec 17 2007, 05:02 AM, said:

If someone else confirms the issue then Leuk_he can move the topic there.

I can confirm this issue with official eMule 0.48a. The GDI handler increased by 5 each time I access the Prefrences-Directories.

[Ergol]

4 GDI not released each time after entering and leaving (by OK/Cancel/switch to other "Options") Options->Directories here.

eMule 0.48a; Windows XP SP2.

Hope it helps.

[Stulle]

Rapid_Mule, on Dec 17 2007, 02:39 AM, said:

Well I hope i get this one right and avoid the wrath of our well "composed" Stulle.
I get GDI leaks after closing Prefrences-Directories the counters just keep going up is it a leak?

PS: just finished monitoring the official 0.48a client and I get the same leaks (It's not me that's leaking, so don't get any fancy ideas you weirdos).

that's a smart post, don't fear my wrath for i will only be annoyed by stupid posts.

anyway, i have little idea what could happen. might be worth looking into it, though. thanks for the report.

[leuk_he]

Moving from morph to official because rapid mule concludes this is in official as well.


PS, @rapidmule
If you want tot debug this you can remove code until the gdi leak no longer happens.

[Rapid_Mule]

leuk_he, on Dec 20 2007, 10:14 PM, said:

Moving from morph to official because rapid mule concludes this is in official as well.


PS, @rapidmule
If you want tot debug this you can remove code until the gdi leak no longer happens.

Well since I have nothing to do on xmas except for wasting my pathetic life on MMORPGs, I've spent sometime trying to debug this issue and here we go:

Quote

TVS_CHECKBOXES
...
Once a tree-view control is created with this style, the style cannot be removed. Instead, you must destroy the control and create a new one in its place. Destroying the tree-view control does not destroy the check box state image list. You must destroy it explicitly. Get the handle to the state image list by sending the tree-view control a TVM_GETIMAGELIST message. Then destroy the image list with ImageList_Destroy.
...

Now since I've got no clue what that means (Really the only time I code something then it's in Perl and only small scripts). Apparently I need to add something like the following:

	// => Start
	HIMAGELIST handle = TreeView_GetImageList(m_wndDirectories.GetHandle(), TVSIL_STATE);
	if (handle != NULL)
		ImageList_Destroy(handle);
	// <= End

I've no Idea where to insert the code, tried CPreferencesDlg::OnDestroy() but then I didn't figure out how to get the m_ShareSelector handle.

HWND CPPgDirectories::GetHandle()
{
	return m_ShareSelector.GetSafeHwnd();
}

Seems to work fine but can't wait to learn more.

[Enig123]

Well, just tried Rapid_Mule's code by putting GetHandle() into PPgDirectories.h, and, or course the first part in CPreferencesDlg::OnDestroy(). It worked as expected. The Gdi Leak gone.

[leuk_he]

please double check if this fixes it:

http://emulemorph.cv...amp;sortby=date

[Rapid_Mule]

leuk_he, on Jan 8 2008, 11:28 PM, said:

please double check if this fixes it:

http://emulemorph.cv...amp;sortby=date

Had to add a declaration for OnDestroy() to be able to compile it.

PPgDirectories.h
...
	DECLARE_MESSAGE_MAP()
...
	afx_msg void OnBnClickedSeltempdiradd();
	afx_msg void OnDestroy();
...

Works like a charm (Leak is gone). Thanks for the tutorial Leuk_he.

[Ergol]

Thanks. During test run the fix seems to be working.

Hope it helps.

[tHeWiZaRdOfDoS]

Just a note: this would be better off to be put into the CDirectoryTreeCtrl class so it will automatically be applied whereever needed.

[Enig123]

WiZ, why not update your eMuleFuture CVS code (it's a long time) so we can be more clear what are you talking about?

[tHeWiZaRdOfDoS]

Currently I have neither much time nor fun working on eMule (personal problems) - I would have to check what my teammates did, first - and I simply do not want that.
However, this fix would be better put into DirectoyTreeCtrl.h:

Quote

DECLARE_MESSAGE_MAP()
afx_msg void OnDestroy(); //>>> FiX
afx_msg void OnTvnItemexpanding(NMHDR *pNMHDR, LRESULT *pResult);

and DirectoryTreeCtrl.cpp:

Quote

ON_WM_CHAR()
ON_WM_DESTROY() //>>> FiX
END_MESSAGE_MAP()

...

//>>> FiX
void CDirectoryTreeCtrl::OnDestroy()
{
HIMAGELIST handle = TreeView_GetImageList(GetSafeHwnd(), TVSIL_STATE);
if (handle != NULL)
ImageList_Destroy(handle);
}
//<<< FiX

Hope that makes it clear. Regards,
WiZ

This post has been edited by tHeWiZaRdOfDoS: 27 January 2008 - 08:44 AM

[Rapid_Mule]

tHeWiZaRdOfDoS, on Jan 27 2008, 10:41 AM, said:

Currently I have neither much time nor fun working on eMule (personal problems) - I would have to check what my teammates did, first - and I simply do not want that.
However, this fix would be better put into DirectoyTreeCtrl.h:

Quote

DECLARE_MESSAGE_MAP()
afx_msg void OnDestroy(); //>>> FiX
afx_msg void OnTvnItemexpanding(NMHDR *pNMHDR, LRESULT *pResult);

and DirectoryTreeCtrl.cpp:

Quote

ON_WM_CHAR()
ON_WM_DESTROY() //>>> FiX
END_MESSAGE_MAP()

...

//>>> FiX
void CDirectoryTreeCtrl::OnDestroy()
{
HIMAGELIST handle = TreeView_GetImageList(GetSafeHwnd(), TVSIL_STATE);
if (handle != NULL)
ImageList_Destroy(handle);
CTreeCtrl::OnDestroy(); // Avoid memleaks
}
//<<< FiX

Hope that makes it clear. Regards,
WiZ

Putting the code there works but introduced new memleaks! It seems we need to do the cleanup our self. I added CTreeCtrl::OnDestroy() after the code and I hope we finally got it.

[tHeWiZaRdOfDoS]

Of course!
This happens if you do not code for some months...