[tHeWiZaRdOfDoS]

Hi there!
Some of the issues were reported earlier but I cannot find the corresponding threads anymore and somehow they didn't get read or just ignored... anyways, I think it'd be good to fix them if I don't mix things up

First of all:
Indexed.cpp @ Clean():

Quote

m_uTotalIndexSource = uTotalSource;
m_uTotalIndexKeyword = uTotalKey;

Is in fact wrong because we also count the (possibly) removed entries... thus, the correct code would be:

Quote

m_uTotalIndexSource = uTotalSource-uRemovedSource;
m_uTotalIndexKeyword = uTotalKey-uRemovedKey;

Indexed.cpp @ AddNotes():

Quote

m_uTotalIndexKeyword++;

Is most probably wrong and should be

Quote

++m_uTotalIndexNotes;

because we are adding NOTES in this function (note that this code is used twice).



Next in Search.cpp @ StorePacket():
I suppose that this:

Quote

// Inc total request answers
m_uAnswers++;

should be

Quote

// Inc total request answers
++m_uTotalRequestAnswers;

as the comment supposes... also appears twice...

Regards,
WiZ

[Some Support]

1 and 2 look indeed like old bugs - (while 1 was also already reported by an amule dev) . Fortunatly none of those will have any major effect. Number 3 is imho right the way it is now, but i would have to look closer into it to be completely sure.

Anyway thanks for potining out.

[tHeWiZaRdOfDoS]

I noticed they didn't get changed in 0.49c - any reason for that?

[tHeWiZaRdOfDoS]

^^ push - is noone reading here, anymore?

[Some Support]

According to the read counter, i can assure you that there are several persons reading this board. In case you mean "is some support not answering this post anymore", well, there isn't much to say about it.
Apperently i forgot to make myself a note and since those bugs were minor i forgot to fix it for the release. If i manange to make myself a note, i might be able to check it for the next release

[tHeWiZaRdOfDoS]

Some Support, on May 13 2009, 11:40 PM, said:

According to the read counter, i can assure you that there are several persons reading this board. In case you mean "is some support not answering this post anymore", well, there isn't much to say about it.

- I didn't want to be that straight but of course I hoped you would answer me as you are the only (visible/active) dev left

Quote

Apperently i forgot to make myself a note and since those bugs were minor i forgot to fix it for the release. If i manange to make myself a note, i might be able to check it for the next release

Great. I think it might not be THAT minor because if the counters aren't adjusted correctly one might end up indexing way too few entries, no? Maybe just on a long run but nontheless it's nice to have it changed.



EDiT && PS: may I suggest something like "Note-It" or do you prefer paper?

This post has been edited by tHeWiZaRdOfDoS: 14 May 2009 - 05:46 AM